Patchwork [v5] neard: new package

login
register
mail settings
Submitter Simon Dawson
Date Dec. 5, 2012, 6:39 p.m.
Message ID <1354732747-5843-1-git-send-email-spdawson@gmail.com>
Download mbox | patch
Permalink /patch/203922/
State Accepted
Headers show

Comments

Simon Dawson - Dec. 5, 2012, 6:39 p.m.
From: Simon Dawson <spdawson@gmail.com>

Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
 v5: Resend
 v4: No changes; patch series version bumped
 v3: Incorporated improvements suggested by Baruch Siach,
     add Arnout Vandecappelle's acks
 v2: Incorporated improvements suggested by Thomas Petazzoni

 package/Config.in       |    1 +
 package/neard/Config.in |   12 ++++++++++++
 package/neard/neard.mk  |   14 ++++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/neard/Config.in
 create mode 100644 package/neard/neard.mk
Peter Korsgaard - Dec. 5, 2012, 7:14 p.m.
>>>>> "spdawson" == spdawson  <spdawson@gmail.com> writes:

 spdawson> From: Simon Dawson <spdawson@gmail.com>
 spdawson> Signed-off-by: Simon Dawson <spdawson@gmail.com>
 spdawson> ---
 spdawson>  v5: Resend
 spdawson>  v4: No changes; patch series version bumped
 spdawson>  v3: Incorporated improvements suggested by Baruch Siach,
 spdawson>      add Arnout Vandecappelle's acks
 spdawson>  v2: Incorporated improvements suggested by Thomas Petazzoni

 spdawson> +config BR2_PACKAGE_NEARD
 spdawson> +	bool "neard"
 spdawson> +	select BR2_PACKAGE_DBUS
 spdawson> +	select BR2_PACKAGE_LIBGLIB2
 spdawson> +	select BR2_PACKAGE_LIBNL

You forgot to add the dependencies for the toolchain options needed by
dbus/libglib2/libnl.

Committed with that fixed, thanks.

 spdawson> +++ b/package/neard/neard.mk
 spdawson> @@ -0,0 +1,14 @@
 spdawson> +#############################################################
 spdawson> +#
 spdawson> +# neard
 spdawson> +#
 spdawson> +#############################################################
 spdawson> +NEARD_VERSION = 0.8
 spdawson> +NEARD_SITE = $(BR2_KERNEL_MIRROR)/linux/network/nfc
 spdawson> +NEARD_LICENSE = GPLv2
 spdawson> +NEARD_LICENSE_FILES = COPYING
 spdawson> +
 spdawson> +NEARD_DEPENDENCIES = dbus libglib2 libnl

I know these will indirectly pull in host-pkgconf, but I think it makes
sense to add it here as well as configure.ac explicitly checks for it.
Peter Korsgaard - Dec. 6, 2012, 5:30 p.m.
>>>>> "Peter" == Peter Korsgaard <jacmet@uclibc.org> writes:

>>>>> "spdawson" == spdawson  <spdawson@gmail.com> writes:
 spdawson> From: Simon Dawson <spdawson@gmail.com>
 spdawson> Signed-off-by: Simon Dawson <spdawson@gmail.com>
 spdawson> ---
 spdawson> v5: Resend
 spdawson> v4: No changes; patch series version bumped
 spdawson> v3: Incorporated improvements suggested by Baruch Siach,
 spdawson> add Arnout Vandecappelle's acks
 spdawson> v2: Incorporated improvements suggested by Thomas Petazzoni

 spdawson> +config BR2_PACKAGE_NEARD
 spdawson> +	bool "neard"
 spdawson> +	select BR2_PACKAGE_DBUS
 spdawson> +	select BR2_PACKAGE_LIBGLIB2
 spdawson> +	select BR2_PACKAGE_LIBNL

 Peter> You forgot to add the dependencies for the toolchain options needed by
 Peter> dbus/libglib2/libnl.

 Peter> Committed with that fixed, thanks.

It seems to cause build failures though - Care to look at it?

http://autobuild.buildroot.net/results/eb2e3e8c604e26738f73b55e788b969d4a3dee23/build-end.log
Simon Dawson - Dec. 6, 2012, 7:41 p.m.
Hi Peter.

On 6 December 2012 17:30, Peter Korsgaard <jacmet@sunsite.dk> wrote:
> It seems to cause build failures though - Care to look at it?
>
> http://autobuild.buildroot.net/results/eb2e3e8c604e26738f73b55e788b969d4a3dee23/build-end.log

The linux/nfc.h kernel header does not exist for pre-3.1.x kernels.
The toolchain used for the autobuild linked above uses 2.6.38 kernel
headers.

To my knowledge, we do not have a mechanism for marking a package as
requiring a [toolchain using a] minimum kernel header version. Is
there a simple way of achieving this, or is it going to require some
new infrastructure?

Simon.

Patch

diff --git a/package/Config.in b/package/Config.in
index f95e29d..4bc5cf3 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -237,6 +237,7 @@  source "package/mdadm/Config.in"
 source "package/memtester/Config.in"
 source "package/minicom/Config.in"
 source "package/nanocom/Config.in"
+source "package/neard/Config.in"
 source "package/ofono/Config.in"
 source "package/open2300/Config.in"
 source "package/openocd/Config.in"
diff --git a/package/neard/Config.in b/package/neard/Config.in
new file mode 100644
index 0000000..a50dbeb
--- /dev/null
+++ b/package/neard/Config.in
@@ -0,0 +1,12 @@ 
+config BR2_PACKAGE_NEARD
+	bool "neard"
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBNL
+	help
+	  Near Field Communication (NFC) manager. This userspace daemon is a part
+	  of the NFC stack provided by the Linux NFC project.
+
+	  http://git.kernel.org/?p=network/nfc/neard.git;a=summary
+
+	  https://01.org/linux-nfc/documentation/how-start-linux-nfc-code...
diff --git a/package/neard/neard.mk b/package/neard/neard.mk
new file mode 100644
index 0000000..28bde71
--- /dev/null
+++ b/package/neard/neard.mk
@@ -0,0 +1,14 @@ 
+#############################################################
+#
+# neard
+#
+#############################################################
+NEARD_VERSION = 0.8
+NEARD_SITE = $(BR2_KERNEL_MIRROR)/linux/network/nfc
+NEARD_LICENSE = GPLv2
+NEARD_LICENSE_FILES = COPYING
+
+NEARD_DEPENDENCIES = dbus libglib2 libnl
+NEARD_CONF_OPT = --disable-traces
+
+$(eval $(autotools-package))