From patchwork Wed Dec 5 18:06:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?=C5=81ukasz_Majewski?= X-Patchwork-Id: 203915 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id CCAD72C009F for ; Thu, 6 Dec 2012 05:07:40 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id B96114A122; Wed, 5 Dec 2012 19:07:23 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5cSgEfp8YaeF; Wed, 5 Dec 2012 19:07:23 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 332464A125; Wed, 5 Dec 2012 19:07:17 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 5BC074A0C1 for ; Wed, 5 Dec 2012 19:07:15 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LZ00GEOCV7dQ for ; Wed, 5 Dec 2012 19:07:14 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by theia.denx.de (Postfix) with ESMTP id 8289A4A0FD for ; Wed, 5 Dec 2012 19:07:07 +0100 (CET) Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MEK00941KZGUD50@mailout2.samsung.com> for u-boot@lists.denx.de; Thu, 06 Dec 2012 03:07:06 +0900 (KST) X-AuditID: cbfee61a-b7fa66d0000004cf-d2-50bf8d4aa588 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 5E.14.01231.A4D8FB05; Thu, 06 Dec 2012 03:07:06 +0900 (KST) Received: from mcdsrvbld02.digital.local ([106.116.37.23]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MEK0010ZKZ8BD10@mmp2.samsung.com> for u-boot@lists.denx.de; Thu, 06 Dec 2012 03:07:06 +0900 (KST) From: Lukasz Majewski To: u-boot@lists.denx.de Date: Wed, 05 Dec 2012 19:06:40 +0100 Message-id: <1354730801-29898-5-git-send-email-l.majewski@samsung.com> X-Mailer: git-send-email 1.7.10 In-reply-to: <1354730801-29898-1-git-send-email-l.majewski@samsung.com> References: <1354730801-29898-1-git-send-email-l.majewski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrEJMWRmVeSWpSXmKPExsVy+t9jQV2v3v0BBv++Slq83dvJ7sDocfbO DsYAxigum5TUnMyy1CJ9uwSujGMfljIW3OKs+NHymrWBsZWji5GDQ0LARGL2K+UuRk4gU0zi wr31bCC2kMB0Romt9626GLmA7MVMEodnTmAFSbAJ6El8vvuUCcQWEZCQ+NV/lRGkiFlgK5PE hUevwIqEBXwlrmx8BVbEIqAqsfzLBrCpvAJuEidXLmWE2CYv8fR+H1icU8BdovXhZ3aIzW4S y97fZ57AyLuAkWEVo2hqQXJBcVJ6rqFecWJucWleul5yfu4mRrDPn0ntYFzZYHGIUYCDUYmH 17J6f4AQa2JZcWXuIUYJDmYlEd5iP6AQb0piZVVqUX58UWlOavEhRmkOFiVx3maPlAAhgfTE ktTs1NSC1CKYLBMHp1QDI9/cDbrtM21/3hZd734hdX6fYNGCeSxPWxc0TN04f1bTZf47sZ8D Xmi9LpJz/nSuNdLd6PkzY0vGN7Ic9y27PB4UrTIs3O2XWhWjY506tyjRifX2y4PPi8OYJ5ms VymweRX5VsJa6ov7q2kBJ4Us6q+Z5KqlTmMRvumlVzspzsgjbsVuHqZzSizFGYmGWsxFxYkA Cno2NfUBAAA= Cc: "pintu.k@samsung.com" , Kyungmin Park , IQBAL SHAREEF , Tom Rini Subject: [U-Boot] [RESEND 4/4] fs:ext4:write: Initialize cache aligned filename buffer X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de The filename buffer is allocated dynamically. It must be cache aligned. Moreover, it is necessary to erase its content before we use it for file name operations. This prevents from corruption of written file names. Signed-off-by: Lukasz Majewski Signed-off-by: Kyungmin Park --- fs/ext4/ext4fs.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/ext4/ext4fs.c b/fs/ext4/ext4fs.c index 64d8a6d..f02c215 100644 --- a/fs/ext4/ext4fs.c +++ b/fs/ext4/ext4fs.c @@ -1011,8 +1011,6 @@ int ext4fs_write(const char *fname, unsigned char *buffer, unsigned int blks_reqd_for_file; unsigned int blocks_remaining; int existing_file_inodeno; - char filename[256]; - char *temp_ptr = NULL; long int itable_blkno; long int parent_itable_blkno; @@ -1021,6 +1019,9 @@ int ext4fs_write(const char *fname, unsigned char *buffer, unsigned int inodes_per_block; unsigned int ibmap_idx; struct ext_filesystem *fs = get_fs(); + ALLOC_CACHE_ALIGN_BUFFER(char, filename, 256); + memset(filename, 0x00, sizeof(filename)); + g_parent_inode = zalloc(sizeof(struct ext2_inode)); if (!g_parent_inode) goto fail;