Patchwork add support for Freescale .sb format to uboot

login
register
mail settings
Submitter Gary Coulbourne
Date Dec. 5, 2012, 4:48 p.m.
Message ID <CAEnpE0yzcer9dNew-6yfwmjf+L+a=Kgrf-tZ++Y2gMRcwmGYLw@mail.gmail.com>
Download mbox | patch
Permalink /patch/203903/
State Accepted
Headers show

Comments

Gary Coulbourne - Dec. 5, 2012, 4:48 p.m.
This patch offers the option to build u-boot.sb

---
 boot/uboot/Config.in |    4 ++++
 boot/uboot/uboot.mk  |    3 +++
 2 files changed, 7 insertions(+)

--
Thomas Petazzoni - Dec. 5, 2012, 5:05 p.m.
Dear Gary Coulbourne,

On Wed, 5 Dec 2012 11:48:27 -0500, Gary Coulbourne wrote:
> This patch offers the option to build u-boot.sb

We had a patch sent in March this year adding support for u-boot.sb:

[Buildroot] [PATCH 2/2] u-boot: add support for u-boot.sb file format

It was more complete than this one, because it included the dependency
on host-elftosb, which is needed to bring the elftosb tool built by
Buildroot before U-Boot uses it to generate the .sb image.

Best regards,

Thomas
Attila Kinali - Dec. 5, 2012, 5:16 p.m.
Moin,

On Wed, 5 Dec 2012 18:05:33 +0100
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> [Buildroot] [PATCH 2/2] u-boot: add support for u-boot.sb file format
> 
> It was more complete than this one, because it included the dependency
> on host-elftosb, which is needed to bring the elftosb tool built by
> Buildroot before U-Boot uses it to generate the .sb image.

Any reason why it has not gotten into the git repo?

			Attila Kinali
Peter Korsgaard - Dec. 5, 2012, 5:46 p.m.
>>>>> "Attila" == Attila Kinali <attila@kinali.ch> writes:

 >> [Buildroot] [PATCH 2/2] u-boot: add support for u-boot.sb file format
 >> 
 >> It was more complete than this one, because it included the dependency
 >> on host-elftosb, which is needed to bring the elftosb tool built by
 >> Buildroot before U-Boot uses it to generate the .sb image.

 Attila> Any reason why it has not gotten into the git repo?

Not really. I don't have any imx hw here. Are you able to test it?
Thomas Petazzoni - Dec. 5, 2012, 7:13 p.m.
Dear Peter Korsgaard,

On Wed, 05 Dec 2012 09:46:50 -0800, Peter Korsgaard wrote:
> >>>>> "Attila" == Attila Kinali <attila@kinali.ch> writes:
> 
>  >> [Buildroot] [PATCH 2/2] u-boot: add support for u-boot.sb file
>  >> format
>  >> 
>  >> It was more complete than this one, because it included the
>  >> dependency on host-elftosb, which is needed to bring the elftosb
>  >> tool built by Buildroot before U-Boot uses it to generate the .sb
>  >> image.
> 
>  Attila> Any reason why it has not gotten into the git repo?
> 
> Not really. I don't have any imx hw here. Are you able to test it?

It was submitted in March by a guy from Armadeus, and they do use i.MX
hardware a lot, so I guess that it works.

Thomas
Attila Kinali - Dec. 5, 2012, 8:27 p.m.
On Wed, 05 Dec 2012 09:46:50 -0800
Peter Korsgaard <jacmet@uclibc.org> wrote:

> >>>>> "Attila" == Attila Kinali <attila@kinali.ch> writes:
> 
>  >> [Buildroot] [PATCH 2/2] u-boot: add support for u-boot.sb file format
>  >> 
>  >> It was more complete than this one, because it included the dependency
>  >> on host-elftosb, which is needed to bring the elftosb tool built by
>  >> Buildroot before U-Boot uses it to generate the .sb image.
> 
>  Attila> Any reason why it has not gotten into the git repo?
> 
> Not really. I don't have any imx hw here. Are you able to test it?

I have an i.mx23 EVK at work. So i guess i could test it.

			Attila Kinali
Peter Korsgaard - Dec. 5, 2012, 9:20 p.m.
>>>>> "Attila" == Attila Kinali <attila@kinali.ch> writes:

 >> Not really. I don't have any imx hw here. Are you able to test it?

 Attila> I have an i.mx23 EVK at work. So i guess i could test it.

Great, thanks.
Attila Kinali - Dec. 17, 2012, 1:52 p.m.
On Wed, 05 Dec 2012 13:20:11 -0800
Peter Korsgaard <jacmet@uclibc.org> wrote:

> >>>>> "Attila" == Attila Kinali <attila@kinali.ch> writes:
> 
>  >> Not really. I don't have any imx hw here. Are you able to test it?
> 
>  Attila> I have an i.mx23 EVK at work. So i guess i could test it.
> 
> Great, thanks.

Sorry, i didnt have time to test it yet.
And unfortunately it doesn't look like i will have time for it
until the end of the week. How it is between christmas and new year,
i cannot tell. But i try to fit it in somehow.

Thanks for your patience and sorry for the delay

			Attila Kinali
Thomas Petazzoni - July 29, 2013, 7:24 p.m.
Dear Gary Coulbourne,

On Wed, 5 Dec 2012 11:48:27 -0500, Gary Coulbourne wrote:
> This patch offers the option to build u-boot.sb
> 
> ---
>  boot/uboot/Config.in |    4 ++++
>  boot/uboot/uboot.mk  |    3 +++
>  2 files changed, 7 insertions(+)

Applied, thanks. I had to add the host-elftosb dependency to make it
work properly.

Thanks,

Thomas

Patch

diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
index d8458d9..9b7a3b0 100644
--- a/boot/uboot/Config.in
+++ b/boot/uboot/Config.in
@@ -94,6 +94,10 @@  config BR2_TARGET_UBOOT_FORMAT_AIS
   It is required to load code/data on OMAP-L1 processors.
   u-boot.ais contains U-Boot with the SPL support.

+config BR2_TARGET_UBOOT_FORMAT_SB
+        depends on BR2_arm
+        bool "u-boot.sb"
+
 config BR2_TARGET_UBOOT_FORMAT_BIN
  bool "u-boot.bin"

diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index 619f2e1..4a98583 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -37,6 +37,9 @@  else ifeq ($(BR2_TARGET_UBOOT_FORMAT_NAND_BIN),y)
 UBOOT_BIN          = u-boot-nand.bin
 else ifeq ($(BR2_TARGET_UBOOT_FORMAT_IMG),y)
 UBOOT_BIN          = u-boot.img
+else ifeq ($(BR2_TARGET_UBOOT_FORMAT_SB),y)
+UBOOT_BIN          = u-boot.sb
+UBOOT_MAKE_TARGET  = $(UBOOT_BIN)
 else
 UBOOT_BIN          = u-boot.bin
 UBOOT_BIN_IFT      = $(UBOOT_BIN).ift