Patchwork ext4: unneeded variable in ext4_try_add_inline_entry()

login
register
mail settings
Submitter Dan Carpenter
Date Dec. 5, 2012, 8:08 a.m.
Message ID <20121205080836.GA10259@elgon.mountain>
Download mbox | patch
Permalink /patch/203800/
State Accepted
Headers show

Comments

Dan Carpenter - Dec. 5, 2012, 8:08 a.m.
We never actually use "backup_buf" so I have removed it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Theodore Ts'o - Dec. 6, 2012, 5:23 p.m.
On Wed, Dec 05, 2012 at 11:08:37AM +0300, Dan Carpenter wrote:
> We never actually use "backup_buf" so I have removed it.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

I've merged this into the inline data patches; thanks for reporting it!

     	    	      	  	      - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index 1fe0cc4..26e4218 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -1224,7 +1224,7 @@  int ext4_try_add_inline_entry(handle_t *handle, struct dentry *dentry,
 			      struct inode *inode)
 {
 	int ret, inline_size;
-	void *inline_start, *backup_buf = NULL;
+	void *inline_start;
 	struct ext4_iloc iloc;
 	struct inode *dir = dentry->d_parent->d_inode;
 
@@ -1276,7 +1276,6 @@  int ext4_try_add_inline_entry(handle_t *handle, struct dentry *dentry,
 	ret = ext4_convert_inline_data_nolock(handle, dir, &iloc);
 
 out:
-	kfree(backup_buf);
 	ext4_mark_inode_dirty(handle, dir);
 	up_write(&EXT4_I(dir)->xattr_sem);
 	brelse(iloc.bh);