From patchwork Tue Dec 4 13:39:38 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: ext4: Fix a build warning in __ext4_journalled_writepage. From: Tao Ma X-Patchwork-Id: 203634 Message-Id: <1354628379-3047-1-git-send-email-tm@tao.ma> To: linux-ext4@vger.kernel.org Cc: "Theodore Ts'o" Date: Tue, 4 Dec 2012 21:39:38 +0800 From: Tao Ma smatch complains: fs/ext4/inode.c:1953 __ext4_journalled_writepage() error: potential NULL dereference 'page_bufs'. So add the check for it. Reported-by: Dan Carpenter Cc: "Theodore Ts'o" Signed-off-by: Tao Ma --- fs/ext4/inode.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index dbc5784..431201b 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -1956,7 +1956,7 @@ static int __ext4_journalled_writepage(struct page *page, struct buffer_head *page_bufs = NULL; handle_t *handle = NULL; int ret = 0; - int err; + int err = 0; struct buffer_head *inode_bh = NULL; ClearPageChecked(page); @@ -1987,8 +1987,7 @@ static int __ext4_journalled_writepage(struct page *page, ret = ext4_journal_get_write_access(handle, inode_bh); err = ext4_handle_dirty_metadata(handle, inode, inode_bh); - - } else { + } else if (page_bufs) { ret = ext4_walk_page_buffers(handle, page_bufs, 0, len, NULL, do_journal_get_write_access);