Patchwork data/klog.json: Update a parse/execution failure advice line

login
register
mail settings
Submitter Colin King
Date Dec. 4, 2012, 11:03 a.m.
Message ID <1354618983-5671-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/203597/
State Accepted
Headers show

Comments

Colin King - Dec. 4, 2012, 11:03 a.m.
From: Colin Ian King <colin.king@canonical.com>

The parse/execution failure advice should be a little less specific
because we're not sure if it fails during a parse or execution.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Keng-Yu Lin - Dec. 6, 2012, 7:30 a.m.
On Tue, Dec 4, 2012 at 7:03 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The parse/execution failure advice should be a little less specific
> because we're not sure if it fails during a parse or execution.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index c2cc858..bf6a2f5 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2738,7 +2738,7 @@
>     "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
>     "pattern": "Method parse/execution failed",
> -   "advice": "The ACPI driver encounter a parsing error on some ACPI AML code. This is unexepcted and normally indicates that there is a bug in the compiled AML code.  It could be a programming fault or an AML compiler issue.  See acpi_ps_parse_aml().",
> +   "advice": "The ACPI driver encounter a parse or execution error on some ACPI AML code. This is unexepcted and normally indicates that there is a bug in the compiled AML code.  It could be a programming fault or an AML compiler issue.  See acpi_ps_parse_aml().",
>     "label": "KlogAcpiParseExecAmlFailed"
>    },
>    {
> --
> 1.8.0
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - Dec. 12, 2012, 9:49 a.m.
On 12/04/2012 07:03 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The parse/execution failure advice should be a little less specific
> because we're not sure if it fails during a parse or execution.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index c2cc858..bf6a2f5 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2738,7 +2738,7 @@
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
>      "pattern": "Method parse/execution failed",
> -   "advice": "The ACPI driver encounter a parsing error on some ACPI AML code. This is unexepcted and normally indicates that there is a bug in the compiled AML code.  It could be a programming fault or an AML compiler issue.  See acpi_ps_parse_aml().",
> +   "advice": "The ACPI driver encounter a parse or execution error on some ACPI AML code. This is unexepcted and normally indicates that there is a bug in the compiled AML code.  It could be a programming fault or an AML compiler issue.  See acpi_ps_parse_aml().",
>      "label": "KlogAcpiParseExecAmlFailed"
>     },
>     {
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index c2cc858..bf6a2f5 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -2738,7 +2738,7 @@ 
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
    "pattern": "Method parse/execution failed",
-   "advice": "The ACPI driver encounter a parsing error on some ACPI AML code. This is unexepcted and normally indicates that there is a bug in the compiled AML code.  It could be a programming fault or an AML compiler issue.  See acpi_ps_parse_aml().",
+   "advice": "The ACPI driver encounter a parse or execution error on some ACPI AML code. This is unexepcted and normally indicates that there is a bug in the compiled AML code.  It could be a programming fault or an AML compiler issue.  See acpi_ps_parse_aml().",
    "label": "KlogAcpiParseExecAmlFailed"
   },
   {