From patchwork Tue Dec 4 06:04:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Crosthwaite X-Patchwork-Id: 203566 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3F2012C0092 for ; Tue, 4 Dec 2012 17:05:35 +1100 (EST) Received: from localhost ([::1]:43397 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfldN-0006HW-61 for incoming@patchwork.ozlabs.org; Tue, 04 Dec 2012 01:05:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tfld1-0005p2-RI for qemu-devel@nongnu.org; Tue, 04 Dec 2012 01:05:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tflcv-00024f-5j for qemu-devel@nongnu.org; Tue, 04 Dec 2012 01:05:11 -0500 Received: from mail-ia0-f173.google.com ([209.85.210.173]:55559) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tflcv-0001w0-1J for qemu-devel@nongnu.org; Tue, 04 Dec 2012 01:05:05 -0500 Received: by mail-ia0-f173.google.com with SMTP id w21so2752334iac.4 for ; Mon, 03 Dec 2012 22:05:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:in-reply-to:references:x-gm-message-state; bh=AGe2MbHE9Z6tBNiLXbMD/5EaN/B2RgMDokZ/Effo44A=; b=k/aAWjteap71gKcqecNDDwH1ofRKKjkp3mkLUcGSKMTeetvPHpC2pC3xT4YPFJA7W0 whGeREuoZbZUl6Krtm6QbFz6XUYD/YgnnDHjgM6VuZxCdjN5Cb7gvzqoKi3UN5g2gT8S WqjIUDGY82QPVSSF8VHePL31P5QreVIh+O7Veyokcq0M2jafg2V6G8iaydoBY+iRtOn+ 6JQci2Fo28Cn+L5XjX/V5XSL4gYLBiV/HZ6N1CDJU3xEZdxXZQH/6dEXXBvok7p4EYmZ UVKuXXbGDyD7VhhI2jn9fYaDwKSH2uhCA3/a4yWeG1YfWDIOags9xOgVjrTZWeuFwAw3 U3hg== Received: by 10.42.212.4 with SMTP id gq4mr10138268icb.38.1354601104704; Mon, 03 Dec 2012 22:05:04 -0800 (PST) Received: from localhost ([124.148.20.9]) by mx.google.com with ESMTPS id xn10sm9164123igb.4.2012.12.03.22.05.02 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 03 Dec 2012 22:05:04 -0800 (PST) From: Peter Crosthwaite To: qemu-devel@nongnu.org, qemu-trivial@nongnu.org Date: Tue, 4 Dec 2012 16:04:33 +1000 Message-Id: <6e3d31ea164ba3e26312398c7382f247023654bb.1354600680.git.peter.crosthwaite@xilinx.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: References: In-Reply-To: References: X-Gm-Message-State: ALoCoQn6giYdEG3YPo5uytuX9luMdUsiNh7YCu0e7byBVUon2ugJ+jyI4llvooTbdOhvKw8DVqgB X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.210.173 Cc: peter.maydell@linaro.org, Peter Crosthwaite Subject: [Qemu-devel] [PATCH v1 1/4] pflash_cfi01: qemu_log_mask "unimplemented" msg X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This printf is informing the user of unimplemented functionality. It should be re-directed to qemu_log(LOG_UNIMP, ...) accordingly. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- hw/pflash_cfi01.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c index 7d040b5..f9f8e5d 100644 --- a/hw/pflash_cfi01.c +++ b/hw/pflash_cfi01.c @@ -438,9 +438,9 @@ static void pflash_write(pflash_t *pfl, hwaddr offset, return; error_flash: - printf("%s: Unimplemented flash cmd sequence " - "(offset " TARGET_FMT_plx ", wcycle 0x%x cmd 0x%x value 0x%x)\n", - __func__, offset, pfl->wcycle, pfl->cmd, value); + qemu_log_mask(LOG_UNIMP, "%s: Unimplemented flash cmd sequence " + "(offset " TARGET_FMT_plx ", wcycle 0x%x cmd 0x%x value 0x%x)" + "\n", __func__, offset, pfl->wcycle, pfl->cmd, value); reset_flash: memory_region_rom_device_set_readable(&pfl->mem, true);