Patchwork [v1,1/4] pflash_cfi01: qemu_log_mask "unimplemented" msg

login
register
mail settings
Submitter Peter Crosthwaite
Date Dec. 4, 2012, 6:04 a.m.
Message ID <6e3d31ea164ba3e26312398c7382f247023654bb.1354600680.git.peter.crosthwaite@xilinx.com>
Download mbox | patch
Permalink /patch/203566/
State New
Headers show

Comments

Peter Crosthwaite - Dec. 4, 2012, 6:04 a.m.
This printf is informing the user of unimplemented functionality. It should be
re-directed to qemu_log(LOG_UNIMP, ...) accordingly.

Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---

 hw/pflash_cfi01.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Peter Maydell - Dec. 4, 2012, 6:18 p.m.
On 4 December 2012 06:04, Peter Crosthwaite
<peter.crosthwaite@xilinx.com> wrote:
> This printf is informing the user of unimplemented functionality. It should be
> re-directed to qemu_log(LOG_UNIMP, ...) accordingly.
>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

I'm going to assume this series will go through -trivial
rather than arm-devs.

-- PMM

Patch

diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c
index 7d040b5..f9f8e5d 100644
--- a/hw/pflash_cfi01.c
+++ b/hw/pflash_cfi01.c
@@ -438,9 +438,9 @@  static void pflash_write(pflash_t *pfl, hwaddr offset,
     return;
 
  error_flash:
-    printf("%s: Unimplemented flash cmd sequence "
-           "(offset " TARGET_FMT_plx ", wcycle 0x%x cmd 0x%x value 0x%x)\n",
-           __func__, offset, pfl->wcycle, pfl->cmd, value);
+    qemu_log_mask(LOG_UNIMP, "%s: Unimplemented flash cmd sequence "
+                  "(offset " TARGET_FMT_plx ", wcycle 0x%x cmd 0x%x value 0x%x)"
+                  "\n", __func__, offset, pfl->wcycle, pfl->cmd, value);
 
  reset_flash:
     memory_region_rom_device_set_readable(&pfl->mem, true);