Patchwork [-next,POWERPC] celleb: use for_each_compatible_node() macro

login
register
mail settings
Submitter Wei Yongjun
Date Dec. 4, 2012, 5:17 a.m.
Message ID <CAPgLHd-QN0vH3F+Ws8DMrjZOh5vvsjEB0tMOUGFjqtbuwksn-g@mail.gmail.com>
Download mbox | patch
Permalink /patch/203558/
State Accepted
Commit 176ebf8736ee87e3bac4b4a8cbd95a5ca18dbec7
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Wei Yongjun - Dec. 4, 2012, 5:17 a.m.
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Use for_each_compatible_node() macro instead of open coding it.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 arch/powerpc/platforms/cell/celleb_scc_sio.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Patch

diff --git a/arch/powerpc/platforms/cell/celleb_scc_sio.c b/arch/powerpc/platforms/cell/celleb_scc_sio.c
index 3a16c5b..75d71a7 100644
--- a/arch/powerpc/platforms/cell/celleb_scc_sio.c
+++ b/arch/powerpc/platforms/cell/celleb_scc_sio.c
@@ -42,14 +42,13 @@  static struct {
 static int __init txx9_serial_init(void)
 {
 	extern int early_serial_txx9_setup(struct uart_port *port);
-	struct device_node *node = NULL;
+	struct device_node *node;
 	int i;
 	struct uart_port req;
 	struct of_irq irq;
 	struct resource res;
 
-	while ((node = of_find_compatible_node(node,
-				"serial", "toshiba,sio-scc")) != NULL) {
+	for_each_compatible_node(node, "serial", "toshiba,sio-scc") {
 		for (i = 0; i < ARRAY_SIZE(txx9_scc_tab); i++) {
 			if (!(txx9_serial_bitmap & (1<<i)))
 				continue;