Patchwork [09/13] pseries: Don't allow TCE (iommu) tables to be registered with duplicate LIOBNs

login
register
mail settings
Submitter David Gibson
Date Dec. 4, 2012, 2:42 a.m.
Message ID <1354588937-27122-10-git-send-email-david@gibson.dropbear.id.au>
Download mbox | patch
Permalink /patch/203546/
State New
Headers show

Comments

David Gibson - Dec. 4, 2012, 2:42 a.m.
The PAPR specification requires that every bus or device mediated by the
IOMMU have a unique Logical IO Bus Number (LIOBN).  This patch adds a check
to enforce this, which will help catch errors in configuration earlier.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/spapr_iommu.c |    6 ++++++
 1 file changed, 6 insertions(+)

Patch

diff --git a/hw/spapr_iommu.c b/hw/spapr_iommu.c
index 02d78cc..3011b25 100644
--- a/hw/spapr_iommu.c
+++ b/hw/spapr_iommu.c
@@ -120,6 +120,12 @@  DMAContext *spapr_tce_new_dma_context(uint32_t liobn, size_t window_size)
 {
     sPAPRTCETable *tcet;
 
+    if (spapr_tce_find_by_liobn(liobn)) {
+        fprintf(stderr, "Attempted to create TCE table with duplicate"
+                " LIOBN 0x%x\n", liobn);
+        return NULL;
+    }
+
     if (!window_size) {
         return NULL;
     }