Patchwork [12/13] pseries: Increase default NVRAM size

login
register
mail settings
Submitter David Gibson
Date Dec. 4, 2012, 2:42 a.m.
Message ID <1354588937-27122-13-git-send-email-david@gibson.dropbear.id.au>
Download mbox | patch
Permalink /patch/203542/
State New
Headers show

Comments

David Gibson - Dec. 4, 2012, 2:42 a.m.
If no image file for NVRAM is specified, the pseries machine currently
creates a 16K non-persistent NVRAM by default.  This basically works, but
is not large enough for current firmware and guest kernels to create all
the NVRAM partitions they would like to.  Increasing the default size to
64K addresses this and stops the guest generating error messages.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/spapr_nvram.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Alexander Graf - Dec. 13, 2012, 12:51 p.m.
On 04.12.2012, at 03:42, David Gibson wrote:

> If no image file for NVRAM is specified, the pseries machine currently
> creates a 16K non-persistent NVRAM by default.  This basically works, but
> is not large enough for current firmware and guest kernels to create all
> the NVRAM partitions they would like to.  Increasing the default size to
> 64K addresses this and stops the guest generating error messages.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Thanks, applied to ppc-next.


Alex

Patch

diff --git a/hw/spapr_nvram.c b/hw/spapr_nvram.c
index 641de48..512bb8d 100644
--- a/hw/spapr_nvram.c
+++ b/hw/spapr_nvram.c
@@ -37,7 +37,7 @@  typedef struct sPAPRNVRAM {
 } sPAPRNVRAM;
 
 #define MIN_NVRAM_SIZE 8192
-#define DEFAULT_NVRAM_SIZE 16384
+#define DEFAULT_NVRAM_SIZE 65536
 #define MAX_NVRAM_SIZE (UINT16_MAX * 16)
 
 static void rtas_nvram_fetch(sPAPREnvironment *spapr,