From patchwork Mon Dec 3 22:08:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 203458 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5A31B2C00A8 for ; Tue, 4 Dec 2012 09:17:26 +1100 (EST) Received: from localhost ([::1]:52333 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfeKK-00029J-7w for incoming@patchwork.ozlabs.org; Mon, 03 Dec 2012 17:17:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfeIp-0007sX-5K for qemu-devel@nongnu.org; Mon, 03 Dec 2012 17:15:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfeIk-00038B-RF for qemu-devel@nongnu.org; Mon, 03 Dec 2012 17:15:50 -0500 Received: from mail-ie0-f173.google.com ([209.85.223.173]:43922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfeIh-0002tM-Il; Mon, 03 Dec 2012 17:15:43 -0500 Received: by mail-ie0-f173.google.com with SMTP id e13so4875430iej.4 for ; Mon, 03 Dec 2012 14:15:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=GxpUW0TUcqyzb7tEUVuFMzvo7dFRe1JQog5HMAqILPI=; b=u4iRfjphRDV6jwtRC6W6G6MqSI7y4z2UUjjGWGE6R08Y5MWD0/qLOdynpAHFNTeUEp oPdHzT5oYOZ1GX3OUSOjDAI1SmJBl4EHwisRwSMal9+3tP02yuYXfgrD87gctEW3ggHG mg5GogMdLPOx4zfV1ZQtpBhBkErYjqTZM3rXC0oZ3dAZk3Qko+Oe5+DjFQynmb1CAnDo +5Fv0p8Zp3xIahoEGEgoswIsHtMQNJxfTUDQQsMRoX6uKs7N8JlB1SqtVRxdS76QPr05 rhOtvs6h6eK20AV7t8Qs1hrtwPFEKRUacDye5E3481ZTwMfcCw0digkidtFR7shhBhRM R+/w== Received: by 10.50.56.195 with SMTP id c3mr604211igq.30.1354572943358; Mon, 03 Dec 2012 14:15:43 -0800 (PST) Received: from localhost ([32.97.110.59]) by mx.google.com with ESMTPS id ff4sm8119034igc.13.2012.12.03.14.15.42 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 03 Dec 2012 14:15:42 -0800 (PST) From: Michael Roth To: qemu-stable@nongnu.org Date: Mon, 3 Dec 2012 16:08:45 -0600 Message-Id: <1354572547-21271-22-git-send-email-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1354572547-21271-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1354572547-21271-1-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.223.173 Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 21/43] target-mips: fix wrong microMIPS opcode encoding X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: "陳韋任 (Wei-Ren Chen)" While reading microMIPS decoding, I found a possible wrong opcode encoding. According to [1] page 166, the bits 13..12 for MULTU is 0x01 rather than 0x00. Please review, thanks. [1] MIPS Architecture for Programmers VolumeIV-e: The MIPS DSP Application-Specific Extension to the microMIPS32 Architecture Signed-off-by: Chen Wei-Ren Signed-off-by: Aurelien Jarno (cherry picked from commit 6801038bc52d61f81ac8a25fbe392f1bad982887) Signed-off-by: Michael Roth --- target-mips/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 4e04e97..49907bb 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -9486,7 +9486,7 @@ enum { /* bits 13..12 for 0x32 */ MULT_ACC = 0x0, - MULTU_ACC = 0x0, + MULTU_ACC = 0x1, /* bits 15..12 for 0x2c */ SEB = 0x2,