| Message ID | CAPgLHd_esknTwVv4EeehwSJz6ee5eFJ+zf6xntH-vaNwdxkrvg@mail.gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | 5444d639ec360679977758d5e896386c6b1babff |
| Delegated to: | Kumar Gala |
| Headers | show |
On Mon, 3 Dec 2012 08:36:03 -0500, Wei Yongjun <weiyj.lk@gmail.com> wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Use for_each_compatible_node() macro instead of open coding it. > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Acked-by: Grant Likely <grant.likely@secretlab.ca> > --- > arch/powerpc/platforms/85xx/mpc85xx_mds.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c b/arch/powerpc/platforms/85xx/mpc85xx_mds.c > index bd12588..a7b3621 100644 > --- a/arch/powerpc/platforms/85xx/mpc85xx_mds.c > +++ b/arch/powerpc/platforms/85xx/mpc85xx_mds.c > @@ -206,9 +206,7 @@ static void __init mpc85xx_mds_reset_ucc_phys(void) > setbits8(&bcsr_regs[7], BCSR7_UCC12_GETHnRST); > clrbits8(&bcsr_regs[8], BCSR8_UEM_MARVELL_RST); > > - for (np = NULL; (np = of_find_compatible_node(np, > - "network", > - "ucc_geth")) != NULL;) { > + for_each_compatible_node(np, "network", "ucc_geth") { > const unsigned int *prop; > int ucc_num; > >
On Dec 3, 2012, at 7:36 AM, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Use for_each_compatible_node() macro instead of open coding it. > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > --- > arch/powerpc/platforms/85xx/mpc85xx_mds.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) applied to next - k
diff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c b/arch/powerpc/platforms/85xx/mpc85xx_mds.c index bd12588..a7b3621 100644 --- a/arch/powerpc/platforms/85xx/mpc85xx_mds.c +++ b/arch/powerpc/platforms/85xx/mpc85xx_mds.c @@ -206,9 +206,7 @@ static void __init mpc85xx_mds_reset_ucc_phys(void) setbits8(&bcsr_regs[7], BCSR7_UCC12_GETHnRST); clrbits8(&bcsr_regs[8], BCSR8_UEM_MARVELL_RST); - for (np = NULL; (np = of_find_compatible_node(np, - "network", - "ucc_geth")) != NULL;) { + for_each_compatible_node(np, "network", "ucc_geth") { const unsigned int *prop; int ucc_num;