| Message ID | 1354527928-27472-1-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Sachin Kamat <sachin.kamat@linaro.org> Date: Mon, 3 Dec 2012 15:15:28 +0530 > linux/version.h inclusion is not necessary. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Acked-by: David S. Miller <davem@davemloft.net> I hope the mvneta folks will pick this up and apply it where it needs to be as the mvneta driver isn't in the net-next tree. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Dear David Miller, On Mon, 03 Dec 2012 13:46:20 -0500 (EST), David Miller wrote: > From: Sachin Kamat <sachin.kamat@linaro.org> > Date: Mon, 3 Dec 2012 15:15:28 +0530 > > > linux/version.h inclusion is not necessary. > > > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > > Acked-by: David S. Miller <davem@davemloft.net> > > I hope the mvneta folks will pick this up and apply it where it > needs to be as the mvneta driver isn't in the net-next tree. Yes, I will pick it up, and send a pull request to the Marvell maintainers. I have other mvneta fixes that I'll send together with this one. Thanks, Thomas
Hi Thomas, On 4 December 2012 00:28, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear David Miller, > > On Mon, 03 Dec 2012 13:46:20 -0500 (EST), David Miller wrote: >> From: Sachin Kamat <sachin.kamat@linaro.org> >> Date: Mon, 3 Dec 2012 15:15:28 +0530 >> >> > linux/version.h inclusion is not necessary. >> > >> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> >> Acked-by: David S. Miller <davem@davemloft.net> >> >> I hope the mvneta folks will pick this up and apply it where it >> needs to be as the mvneta driver isn't in the net-next tree. > > Yes, I will pick it up, and send a pull request to the Marvell > maintainers. I have other mvneta fixes that I'll send together with > this one. Can you please share the git repo link where this patch is lined up ATM? > > Thanks, > > Thomas > -- > Thomas Petazzoni, Free Electrons > Kernel, drivers, real-time and embedded Linux > development, consulting, training and support. > http://free-electrons.com
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 3f8086b..a1e0e9f 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -12,7 +12,6 @@ */ #include <linux/kernel.h> -#include <linux/version.h> #include <linux/netdevice.h> #include <linux/etherdevice.h> #include <linux/platform_device.h>
linux/version.h inclusion is not necessary. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/net/ethernet/marvell/mvneta.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)