Patchwork [powerpc] Fix MAX_STACK_TRACE_ENTRIES too low warning for ppc32

login
register
mail settings
Submitter Li Zhong
Date Dec. 3, 2012, 6:19 a.m.
Message ID <1354515562.3243.27.camel@ThinkPad-T5421.cn.ibm.com>
Download mbox | patch
Permalink /patch/203294/
State Accepted
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Li Zhong - Dec. 3, 2012, 6:19 a.m.
This patch fixes MAX_STACK_TRACE_ENTRIES too low warning for ppc32,
which is similar to commit 12660b17. 

Reported-by: Christian Kujau <lists@nerdbynature.de>
Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
Tested-by: Christian Kujau <lists@nerdbynature.de>
---
 arch/powerpc/kernel/entry_32.S |    2 ++
 1 file changed, 2 insertions(+)
Denis Kirjanov - Dec. 3, 2012, 8:03 a.m.
Could you please provide a more verbose patch description

Thanks.

On 12/3/12, Li Zhong <zhong@linux.vnet.ibm.com> wrote:
> This patch fixes MAX_STACK_TRACE_ENTRIES too low warning for ppc32,
> which is similar to commit 12660b17.
>
> Reported-by: Christian Kujau <lists@nerdbynature.de>
> Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
> Tested-by: Christian Kujau <lists@nerdbynature.de>
> ---
>  arch/powerpc/kernel/entry_32.S |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/kernel/entry_32.S
> b/arch/powerpc/kernel/entry_32.S
> index d22e73e..e514de5 100644
> --- a/arch/powerpc/kernel/entry_32.S
> +++ b/arch/powerpc/kernel/entry_32.S
> @@ -439,6 +439,8 @@ ret_from_fork:
>  ret_from_kernel_thread:
>  	REST_NVGPRS(r1)
>  	bl	schedule_tail
> +	li	r3,0
> +	stw	r3,0(r1)
>  	mtlr	r14
>  	mr	r3,r15
>  	PPC440EP_ERR42
> --
> 1.7.9.5
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
Li Zhong - Dec. 4, 2012, 5:41 a.m.
On Mon, 2012-12-03 at 11:03 +0300, Denis Kirjanov wrote:
> Could you please provide a more verbose patch description

Sorry about the missing background. You may check

[0] http://lkml.indiana.edu/hypermail/linux/kernel/1211.0/03025.html
http://patchwork.ozlabs.org/patch/193414/
http://patchwork.ozlabs.org/patch/202385/

And as it is very similar to that of commit 12660b17, so I think it's
not needed to repeat that in the change log. 

Thanks, Zhong

> 
> Thanks.
> 
> On 12/3/12, Li Zhong <zhong@linux.vnet.ibm.com> wrote:
> > This patch fixes MAX_STACK_TRACE_ENTRIES too low warning for ppc32,
> > which is similar to commit 12660b17.
> >
> > Reported-by: Christian Kujau <lists@nerdbynature.de>
> > Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
> > Tested-by: Christian Kujau <lists@nerdbynature.de>
> > ---
> >  arch/powerpc/kernel/entry_32.S |    2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/powerpc/kernel/entry_32.S
> > b/arch/powerpc/kernel/entry_32.S
> > index d22e73e..e514de5 100644
> > --- a/arch/powerpc/kernel/entry_32.S
> > +++ b/arch/powerpc/kernel/entry_32.S
> > @@ -439,6 +439,8 @@ ret_from_fork:
> >  ret_from_kernel_thread:
> >  	REST_NVGPRS(r1)
> >  	bl	schedule_tail
> > +	li	r3,0
> > +	stw	r3,0(r1)
> >  	mtlr	r14
> >  	mr	r3,r15
> >  	PPC440EP_ERR42
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/linuxppc-dev
> >
> 
>

Patch

diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S
index d22e73e..e514de5 100644
--- a/arch/powerpc/kernel/entry_32.S
+++ b/arch/powerpc/kernel/entry_32.S
@@ -439,6 +439,8 @@  ret_from_fork:
 ret_from_kernel_thread:
 	REST_NVGPRS(r1)
 	bl	schedule_tail
+	li	r3,0
+	stw	r3,0(r1)
 	mtlr	r14
 	mr	r3,r15
 	PPC440EP_ERR42