Patchwork [ext4:dev,45/57] fs/ext4/inline.c:1025:6: sparse: symbol 'ext4_get_inline_xattr_pos' was not declared. Should it be static?

login
register
mail settings
Submitter Wu Fengguang
Date Dec. 3, 2012, 5:20 a.m.
Message ID <50bc36a2.lAcRnrpMvOgx7DsQ%fengguang.wu@intel.com>
Download mbox | patch
Permalink /patch/203290/
State Superseded
Headers show

Comments

Wu Fengguang - Dec. 3, 2012, 5:20 a.m.
tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
head:   b0c30cdb0d3fcf5a04de4a46fceba767cf8be022
commit: 83cd81a477199a3f0c01a609069423d5c6e9805d [45/57] ext4: let add_dir_entry handle inline data properly


sparse warnings:

+ fs/ext4/inline.c:1025:6: sparse: symbol 'ext4_get_inline_xattr_pos' was not declared. Should it be static?

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend         Open Source Technology Center
Fengguang Wu, Yuanhan Liu                              Intel Corporation

Patch

diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index 89d6a25..a39b632 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -1022,7 +1022,7 @@  static int ext4_add_dirent_to_inline(handle_t *handle,
 	return 1;
 }
 
-void *ext4_get_inline_xattr_pos(struct inode *inode, struct ext4_iloc *iloc)
+static void *ext4_get_inline_xattr_pos(struct inode *inode, struct ext4_iloc *iloc)
 {
 	struct ext4_xattr_entry *entry;
 	struct ext4_xattr_ibody_header *header;