From patchwork Mon Dec 3 03:09:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 203281 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 0470D2C00AA for ; Mon, 3 Dec 2012 14:09:46 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A8BBF4A047; Mon, 3 Dec 2012 04:09:43 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nlglEv572dPn; Mon, 3 Dec 2012 04:09:43 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 81FA64A058; Mon, 3 Dec 2012 04:09:42 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 0B7C94A058 for ; Mon, 3 Dec 2012 04:09:37 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K8xtNIHCDl9x for ; Mon, 3 Dec 2012 04:09:36 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-oa0-f44.google.com (mail-oa0-f44.google.com [209.85.219.44]) by theia.denx.de (Postfix) with ESMTPS id DD0CF4A047 for ; Mon, 3 Dec 2012 04:09:35 +0100 (CET) Received: by mail-oa0-f44.google.com with SMTP id n5so2182587oag.3 for ; Sun, 02 Dec 2012 19:09:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=S6pONkDnGtWpLbywzIbQzxdCULpjK8Aq/oKq+c7FTuQ=; b=OuV673OZ3xCMaoFUwJd/2OGcKf7HYXARUgTG4T06Q624NzinMJyUJH0GbpnJuW2y4w iDtDuoqPJ98ANWtgrjLjJq9YhuE1DrtmruR0CQBO9B07Kjqyk1sz5tmy0ZFz33IalULz K6g8bTC5IKLxZoDREAdmj/pbwpupvv2M8ByV7HR+FfpO5aH6gjPvuQ0OFZVcyK7G2Hxm hoErktEp4hektl9TNcCkEow1jSfDLMQ745FQPkPwDkARNYJiz6vaegN5bp2KDa7u9tv/ G8lgLU5r4kQTPsVTPvbW4L15TwWVWMeenscmIrpSoIMdBxizZufh9KLERhFl1Uy3tDO1 O4Tw== Received: by 10.60.11.130 with SMTP id q2mr6984550oeb.141.1354504174628; Sun, 02 Dec 2012 19:09:34 -0800 (PST) Received: from rob-laptop.grandenetworks.net (65-36-73-129.dyn.grandenetworks.net. [65.36.73.129]) by mx.google.com with ESMTPS id o3sm12164184obk.13.2012.12.02.19.09.33 (version=SSLv3 cipher=OTHER); Sun, 02 Dec 2012 19:09:34 -0800 (PST) From: Rob Herring To: u-boot@lists.denx.de Date: Sun, 2 Dec 2012 21:09:26 -0600 Message-Id: <1354504166-1946-1-git-send-email-robherring2@gmail.com> X-Mailer: git-send-email 1.7.10.4 Cc: Joshua Housh Subject: [U-Boot] [PATCH] serial_pl011: Set RTS during initialization X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de From: Joshua Housh If the pl011 is connected to another device which has hardware flow-control on, characters are never received by the pl011. Asserting RTS when flow-control is off will have no effect. This is in line with how Linux behaves. Signed-off-by: Joshua Housh Tested-by: Marek Vasut --- drivers/serial/serial_pl01x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/serial/serial_pl01x.c b/drivers/serial/serial_pl01x.c index b331be7..dfdba9f 100644 --- a/drivers/serial/serial_pl01x.c +++ b/drivers/serial/serial_pl01x.c @@ -163,8 +163,8 @@ static int pl01x_serial_init(void) } #endif /* Finally, enable the UART */ - writel(UART_PL011_CR_UARTEN | UART_PL011_CR_TXE | UART_PL011_CR_RXE, - ®s->pl011_cr); + writel(UART_PL011_CR_UARTEN | UART_PL011_CR_TXE | UART_PL011_CR_RXE | + UART_PL011_CR_RTS, ®s->pl011_cr); return 0; }