From patchwork Sun Dec 2 17:14:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/4] hw/ds1338.c: Fix handling of HOURS register. Date: Sun, 02 Dec 2012 07:14:34 -0000 From: Antoine Mathys X-Patchwork-Id: 203231 Message-Id: <50BB8C7A.7010304@gmail.com> To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, paul@codesourcery.com Per the datasheet, the mapping between 12 and 24 hours modes is: 0 <-> 12 PM 1-12 <-> 1-12 AM 13-23 <-> 1-11 PM Signed-off-by: Antoine Mathys --- hw/ds1338.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/hw/ds1338.c b/hw/ds1338.c index b576d56..1274b22 100644 --- a/hw/ds1338.c +++ b/hw/ds1338.c @@ -50,9 +50,14 @@ static void capture_current_time(DS1338State *s) s->nvram[0] = to_bcd(now.tm_sec); s->nvram[1] = to_bcd(now.tm_min); if (s->nvram[2] & 0x40) { - s->nvram[2] = (to_bcd((now.tm_hour % 12)) + 1) | 0x40; - if (now.tm_hour >= 12) { - s->nvram[2] |= 0x20; + int tmp = now.tm_hour; + if (tmp == 0) { + tmp = 24; + } + if (tmp <= 12) { + s->nvram[2] = 0x40 | to_bcd(tmp); + } else { + s->nvram[2] = 0x60 | to_bcd(tmp - 12); } } else { s->nvram[2] = to_bcd(now.tm_hour); @@ -127,15 +132,17 @@ static int ds1338_send(I2CSlave *i2c, uint8_t data) break; case 2: if (data & 0x40) { + int tmp = from_bcd(data & 0x1f); if (data & 0x20) { - data = from_bcd(data & 0x4f) + 11; - } else { - data = from_bcd(data & 0x1f) - 1; + tmp += 12; + } + if (tmp == 24) { + tmp = 0; } + now.tm_hour = tmp; } else { - data = from_bcd(data); + now.tm_hour = from_bcd(data & 0x3f); } - now.tm_hour = data; break; case 3: now.tm_wday = from_bcd(data & 7) - 1;