From patchwork Sun Dec 2 02:27:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Korsgaard X-Patchwork-Id: 203176 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id CD4C02C00B4 for ; Sun, 2 Dec 2012 13:27:36 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id A2552101564; Sun, 2 Dec 2012 02:27:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 61aGPbS61F0G; Sun, 2 Dec 2012 02:27:24 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 741221001AA; Sun, 2 Dec 2012 02:27:24 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 9BCE38F74A for ; Sun, 2 Dec 2012 02:27:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id A9581864F5 for ; Sun, 2 Dec 2012 02:27:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y+SsVZy70UBY for ; Sun, 2 Dec 2012 02:27:28 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-da0-f43.google.com (mail-da0-f43.google.com [209.85.210.43]) by whitealder.osuosl.org (Postfix) with ESMTPS id 259C3861FD for ; Sun, 2 Dec 2012 02:27:28 +0000 (UTC) Received: by mail-da0-f43.google.com with SMTP id u36so835018dak.16 for ; Sat, 01 Dec 2012 18:27:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=opip+rA4n4WNfBT5EQCajlOkp+4KkZDSYvyVbCHc4wk=; b=W5TdcuviWPXaRw4X1LXd8YdnmsAM53Sw+vDGPOC8lSog6yaxCl/cNdkJl4YHDZLU55 lojoJsIQ+m+c8Mhk1gko9VuD0MiMzDzVBX1JkbuP0lUcG8fRzA1VdQQ2y9DcASIm0dvV xRhAVUVk2xV733N7muPFCpwcF/sfdOtuWqudYfthiq9y4+GfRDGx/hysl4ByAysJf/k6 4lUPwB9HNEQwMcn53uo/vvFnL6TcunAaxjo1r5HlwiJdKs1I3UxpKKh4eJapav7JLgCc 3JGSs89LHjcrwiBNNpYYEm6DK3OfV8syHf+5TaEFRKbpwEHZYDmTURqbytEQQBr6ab1c JDyQ== Received: by 10.68.137.131 with SMTP id qi3mr17840749pbb.114.1354415247595; Sat, 01 Dec 2012 18:27:27 -0800 (PST) Received: from dell.be.48ers.dk (64-71-23-226.static.wiline.com. [64.71.23.226]) by mx.google.com with ESMTPS id oi2sm5586255pbb.62.2012.12.01.18.27.26 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 01 Dec 2012 18:27:26 -0800 (PST) Received: from peko by dell.be.48ers.dk with local (Exim 4.80) (envelope-from ) id 1TezH7-0002o9-9u; Sat, 01 Dec 2012 18:27:21 -0800 From: Peter Korsgaard To: Thomas Petazzoni References: <20121130201152.E2AE89940D@busybox.osuosl.org> <20121201174909.1d52aad3@skate> Date: Sat, 01 Dec 2012 18:27:21 -0800 In-Reply-To: <20121201174909.1d52aad3@skate> (Thomas Petazzoni's message of "Sat, 1 Dec 2012 17:49:09 +0100") Message-ID: <87hao56vee.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Cc: buildroot@busybox.net Subject: Re: [Buildroot] [git commit] pkg-infra: introduce errors for legacy API X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net >>>>> "Thomas" == Thomas Petazzoni writes: Hi, >> As discussed in the BR developer days, we want to be more strict about API >> changes in buildroot. I.e., we want to make it less likely that a user's >> customizations break down after upgrading buildroot. >> >> A first step is to make sure that the user is warned about API changes. >> This patch introduces Makefile.legacy and Config.in.legacy, which will >> issue clear error messages for such situations. >> >> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) >> Signed-off-by: Peter Korsgaard Thomas> This doesn't really work well with randpackageconfig, and therefore Thomas> breaks the autobuilders badly. Thomas> For example, randpackageconfig can enable BR2_PACKAGE_GETTEXT_STATIC, Thomas> because it matches BR2_PACKAGE_, this will select BR2_LEGACY, Thomas> which will abort the build. Thomas> Should it be fixed just in the autobuilders scripts, or do we consider Thomas> the fact that "make randpackageconfig" generates un-buildable Thomas> configuration is a bug by itself? I would call it a bug. I've fixed it like this: [PATCH] {rand,allyes}packageconfig: ensure legacy test options don't get enabled The legacy BR2_PACKAGE_* options in Config.in.legacy are not supposed to be user selectable, so {rand,allyes}packageconfig shouldn't enable them. Signed-off-by: Peter Korsgaard --- Makefile | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Makefile b/Makefile index d3f9b40..b394fd5 100644 --- a/Makefile +++ b/Makefile @@ -619,6 +619,9 @@ allnoconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile randpackageconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile @mkdir -p $(BUILD_DIR)/buildroot-config @grep -v BR2_PACKAGE_ $(CONFIG_DIR)/.config > $(CONFIG_DIR)/.config.nopkg + @grep '^config BR2_PACKAGE_' Config.in.legacy | \ + while read config pkg; do \ + echo "# $$pkg is not set" >> $(CONFIG_DIR)/.config.nopkg; done @$(COMMON_CONFIG_ENV) \ KCONFIG_ALLCONFIG=$(CONFIG_DIR)/.config.nopkg \ $< --randconfig $(CONFIG_CONFIG_IN) @@ -627,6 +630,9 @@ randpackageconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile allyespackageconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile @mkdir -p $(BUILD_DIR)/buildroot-config @grep -v BR2_PACKAGE_ $(CONFIG_DIR)/.config > $(CONFIG_DIR)/.config.nopkg + @grep '^config BR2_PACKAGE_' Config.in.legacy | \ + while read config pkg; do \ + echo "# $$pkg is not set" >> $(CONFIG_DIR)/.config.nopkg; done @$(COMMON_CONFIG_ENV) \ KCONFIG_ALLCONFIG=$(CONFIG_DIR)/.config.nopkg \ $< --allyesconfig $(CONFIG_CONFIG_IN)