From patchwork Sun Dec 2 01:40:28 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cong Ding X-Patchwork-Id: 203167 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 907B42C0080 for ; Sun, 2 Dec 2012 12:40:48 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751550Ab2LBBkp (ORCPT ); Sat, 1 Dec 2012 20:40:45 -0500 Received: from mail-qc0-f174.google.com ([209.85.216.174]:62109 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501Ab2LBBko (ORCPT ); Sat, 1 Dec 2012 20:40:44 -0500 Received: by mail-qc0-f174.google.com with SMTP id o22so931838qcr.19 for ; Sat, 01 Dec 2012 17:40:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=cYjq2vbyfLHmn4CLcLtZLTTtpOpVMGEu3KsloiSYuak=; b=eoJp4cU3KKtv3lNDH/2tGcDcp6MrqxikRi9CeY2t1FI6BZNSBq+1UhTuv5biuuWW2m PR6IbI51SrTUesdnboiVn32IaoXvUeY4iUNfY8U30xs1Gsd+7sYlcgLPXUhfjEjoOg21 MdALtEUjxR261tazxQ9OvvtQKVjOIJQPASjfQ+PzzOMf3WMq/qd2bKunz9f6hVtCU1r2 yXWW4K+pQZXFWmOqPqFMOaU2QCAB5bbYOo1rEWyigPsPDNRAYW+x5vvvCmQGVLqXnTco oQHoNQoPTT47dPS053g2PXM0KTqG5MMIxa8PSRdI/ZViJS3siYMMlwkyRThhiHMp9Ayb etjg== Received: by 10.229.203.89 with SMTP id fh25mr2258710qcb.90.1354412444112; Sat, 01 Dec 2012 17:40:44 -0800 (PST) Received: from localhost.localdomain (ec2-54-243-39-165.compute-1.amazonaws.com. [54.243.39.165]) by mx.google.com with ESMTPS id jw1sm5740219qeb.13.2012.12.01.17.40.42 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 01 Dec 2012 17:40:43 -0800 (PST) From: Cong Ding To: Jan Kara , Andrew Morton , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Cong Ding Subject: [PATCH] fs:ext3: remove lock_buffer in bclean() and setup_new_group_blocks Date: Sun, 2 Dec 2012 01:40:28 +0000 Message-Id: <1354412428-8938-1-git-send-email-dinggnu@gmail.com> X-Mailer: git-send-email 1.7.4.5 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org it's not necessary to lock the buffers because no one touches them beyond the file system. Signed-off-by: Cong Ding --- fs/ext3/resize.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/fs/ext3/resize.c b/fs/ext3/resize.c index 0f814f3..f76fcd6 100644 --- a/fs/ext3/resize.c +++ b/fs/ext3/resize.c @@ -122,10 +122,8 @@ static struct buffer_head *bclean(handle_t *handle, struct super_block *sb, brelse(bh); bh = ERR_PTR(err); } else { - lock_buffer(bh); memset(bh->b_data, 0, sb->s_blocksize); set_buffer_uptodate(bh); - unlock_buffer(bh); } return bh; @@ -242,10 +240,8 @@ static int setup_new_group_blocks(struct super_block *sb, brelse(gdb); goto exit_bh; } - lock_buffer(gdb); memcpy(gdb->b_data, sbi->s_group_desc[i]->b_data, gdb->b_size); set_buffer_uptodate(gdb); - unlock_buffer(gdb); err = ext3_journal_dirty_metadata(handle, gdb); if (err) { brelse(gdb);