From patchwork Sun Dec 2 01:40:28 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: fs:ext3: remove lock_buffer in bclean() and setup_new_group_blocks Date: Sat, 01 Dec 2012 15:40:28 -0000 From: Cong Ding X-Patchwork-Id: 203167 Message-Id: <1354412428-8938-1-git-send-email-dinggnu@gmail.com> To: Jan Kara , Andrew Morton , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Cong Ding it's not necessary to lock the buffers because no one touches them beyond the file system. Signed-off-by: Cong Ding --- fs/ext3/resize.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/fs/ext3/resize.c b/fs/ext3/resize.c index 0f814f3..f76fcd6 100644 --- a/fs/ext3/resize.c +++ b/fs/ext3/resize.c @@ -122,10 +122,8 @@ static struct buffer_head *bclean(handle_t *handle, struct super_block *sb, brelse(bh); bh = ERR_PTR(err); } else { - lock_buffer(bh); memset(bh->b_data, 0, sb->s_blocksize); set_buffer_uptodate(bh); - unlock_buffer(bh); } return bh; @@ -242,10 +240,8 @@ static int setup_new_group_blocks(struct super_block *sb, brelse(gdb); goto exit_bh; } - lock_buffer(gdb); memcpy(gdb->b_data, sbi->s_group_desc[i]->b_data, gdb->b_size); set_buffer_uptodate(gdb); - unlock_buffer(gdb); err = ext3_journal_dirty_metadata(handle, gdb); if (err) { brelse(gdb);