Patchwork fs:ext4:hash.c: reduce one "if" comparison

login
register
mail settings
Submitter Cong Ding
Date Dec. 1, 2012, 11:33 p.m.
Message ID <1354404821-6781-1-git-send-email-dinggnu@gmail.com>
Download mbox | patch
Permalink /patch/203160/
State Accepted
Headers show

Comments

Cong Ding - Dec. 1, 2012, 11:33 p.m.
it is unnecessary to check i<4 after the loop. just do it before the break.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
 fs/ext4/hash.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Theodore Ts'o - Feb. 2, 2013, 3:34 a.m.
On Sat, Dec 01, 2012 at 11:33:41PM +0000, Cong Ding wrote:
> it is unnecessary to check i<4 after the loop. just do it before the break.
> 
> Signed-off-by: Cong Ding <dinggnu@gmail.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/hash.c b/fs/ext4/hash.c
index fa8e491..3d586f0 100644
--- a/fs/ext4/hash.c
+++ b/fs/ext4/hash.c
@@ -155,11 +155,11 @@  int ext4fs_dirhash(const char *name, int len, struct dx_hash_info *hinfo)
 	/* Check to see if the seed is all zero's */
 	if (hinfo->seed) {
 		for (i = 0; i < 4; i++) {
-			if (hinfo->seed[i])
+			if (hinfo->seed[i]) {
+				memcpy(buf, hinfo->seed, sizeof(buf));
 				break;
+			}
 		}
-		if (i < 4)
-			memcpy(buf, hinfo->seed, sizeof(buf));
 	}
 
 	switch (hinfo->hash_version) {