Patchwork Rework RTL CFG graph dumping to dump DOT format

login
register
mail settings
Submitter Steven Bosscher
Date Dec. 1, 2012, 5:40 p.m.
Message ID <CABu31nOeOn0LzfQfG1AFLWwqEJjFoeRE=mLOpvgUMXcHC-0jAQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/203145/
State New
Headers show

Comments

Steven Bosscher - Dec. 1, 2012, 5:40 p.m.
On Sat, Dec 1, 2012 at 2:23 PM, Steven Bosscher wrote:
> On Mon, Nov 26, 2012 at 4:46 PM, Richard Biener wrote:
>> Btw, I of course have my own CFG dumper (producing graphviz input)
>> in my local tree - attached for reference (I'm simply using it from
>> gdb sessions).
>
> Here's my version of it. I still have to fix some minor fall-out of
> not flushing the pretty-printers all over the (inappropriate) place,
> but the graph dumps seem to work nicely so far. Perhaps you can try it
> out and see if this is to your liking? :-)
>
> Bootstrapped&tested on {powerpc64,x86_64}-unknown-linux-gnu. As I
> said: Still fixing some minor tree dump related fall-out.

I only need this fix on top of the patch:



Bootstrapped&tested on powerpc64-unknown-linux-gnu. OK for trunk?

Ciao!
Steven
Richard Guenther - Dec. 3, 2012, 11:05 a.m.
On Sat, Dec 1, 2012 at 6:40 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> On Sat, Dec 1, 2012 at 2:23 PM, Steven Bosscher wrote:
>> On Mon, Nov 26, 2012 at 4:46 PM, Richard Biener wrote:
>>> Btw, I of course have my own CFG dumper (producing graphviz input)
>>> in my local tree - attached for reference (I'm simply using it from
>>> gdb sessions).
>>
>> Here's my version of it. I still have to fix some minor fall-out of
>> not flushing the pretty-printers all over the (inappropriate) place,
>> but the graph dumps seem to work nicely so far. Perhaps you can try it
>> out and see if this is to your liking? :-)
>>
>> Bootstrapped&tested on {powerpc64,x86_64}-unknown-linux-gnu. As I
>> said: Still fixing some minor tree dump related fall-out.
>
> I only need this fix on top of the patch:
>
> diff -u tree-pretty-print.c tree-pretty-print.c
> --- tree-pretty-print.c (working copy)
> +++ tree-pretty-print.c (working copy)
> @@ -161,6 +161,7 @@
>  {
>    maybe_init_pretty_print (file);
>    dump_generic_node (&buffer, t, 0, flags, false);
> +  pp_flush (&buffer);
>  }
>
>  /* Dump the name of a _DECL node and its DECL_UID if TDF_UID is set
>
>
> Bootstrapped&tested on powerpc64-unknown-linux-gnu. OK for trunk?

Nice.

Ok!

Thanks,
Richard.

> Ciao!
> Steven

Patch

diff -u tree-pretty-print.c tree-pretty-print.c
--- tree-pretty-print.c (working copy)
+++ tree-pretty-print.c (working copy)
@@ -161,6 +161,7 @@ 
 {
   maybe_init_pretty_print (file);
   dump_generic_node (&buffer, t, 0, flags, false);
+  pp_flush (&buffer);
 }

 /* Dump the name of a _DECL node and its DECL_UID if TDF_UID is set