Patchwork reorder fs alphabetically

login
register
mail settings
Submitter Jeremy Rosen
Date Nov. 30, 2012, 1:08 p.m.
Message ID <1354280931-10379-1-git-send-email-jeremy.rosen@openwide.fr>
Download mbox | patch
Permalink /patch/202946/
State Superseded
Headers show

Comments

Jeremy Rosen - Nov. 30, 2012, 1:08 p.m.
Signed-off-by: Jérémy Rosen <jeremy.rosen@openwide.fr>
---
when adding the live target I was asked to add it in alphabetical order to
the fs list

however that list was unsorted. This patch reorders FS properly (it doesn't add the live fs)
---
 fs/Config.in |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Will Moore - Nov. 30, 2012, 1:44 p.m.
Hi Jeremy,

> -----Original Message-----
> From: buildroot-bounces@busybox.net [mailto:buildroot-bounces@busybox.net] On
> Behalf Of Jérémy Rosen
> Sent: 30 November 2012 13:09
> 
> Signed-off-by: Jérémy Rosen <jeremy.rosen@openwide.fr>
> ---
> when adding the live target I was asked to add it in alphabetical order to
> the fs list
> 
> however that list was unsorted. This patch reorders FS properly (it doesn't
> add the live fs)
> ---
>  fs/Config.in |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/Config.in b/fs/Config.in
> index 94154ea..e970075 100644
> --- a/fs/Config.in
> +++ b/fs/Config.in
> @@ -4,12 +4,12 @@ source "fs/cramfs/Config.in"
>  source "fs/cloop/Config.in"
>  source "fs/ext2/Config.in"
>  source "fs/jffs2/Config.in"
> -source "fs/ubifs/Config.in"
> -source "fs/squashfs/Config.in"
> -source "fs/tar/Config.in"
>  source "fs/cpio/Config.in"
> -source "fs/iso9660/Config.in"
>  source "fs/initramfs/Config.in"
> +source "fs/iso9660/Config.in"
>  source "fs/romfs/Config.in"
> +source "fs/squashfs/Config.in"
> +source "fs/tar/Config.in"
> +source "fs/ubifs/Config.in"

Perhaps I misunderstand, but I would have thought cloop should be before cramfs,
jffs2 after iso9660 and cpio before ext2?

Will

> 
>  endmenu
> --
> 1.7.10.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Jeremy Rosen - Nov. 30, 2012, 2:06 p.m.
ok....

let's just say it's friday and I really need a week-end :P

sorry about that, v2 to come soon



    Cordialement

    Jérémy Rosen

fight key loggers : write some perl using vim

----- Mail original -----
> De: "Will Moore" <will.moore@beraninstruments.com>
> À: "Jérémy Rosen" <jeremy.rosen@openwide.fr>, buildroot@busybox.net
> Envoyé: Vendredi 30 Novembre 2012 14:44:17
> Objet: RE: [Buildroot] [PATCH] [PATCH] reorder fs alphabetically
> 
> Hi Jeremy,
> 
> > -----Original Message-----
> > From: buildroot-bounces@busybox.net
> > [mailto:buildroot-bounces@busybox.net] On
> > Behalf Of Jérémy Rosen
> > Sent: 30 November 2012 13:09
> > 
> > Signed-off-by: Jérémy Rosen <jeremy.rosen@openwide.fr>
> > ---
> > when adding the live target I was asked to add it in alphabetical
> > order to
> > the fs list
> > 
> > however that list was unsorted. This patch reorders FS properly (it
> > doesn't
> > add the live fs)
> > ---
> >  fs/Config.in |    8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/fs/Config.in b/fs/Config.in
> > index 94154ea..e970075 100644
> > --- a/fs/Config.in
> > +++ b/fs/Config.in
> > @@ -4,12 +4,12 @@ source "fs/cramfs/Config.in"
> >  source "fs/cloop/Config.in"
> >  source "fs/ext2/Config.in"
> >  source "fs/jffs2/Config.in"
> > -source "fs/ubifs/Config.in"
> > -source "fs/squashfs/Config.in"
> > -source "fs/tar/Config.in"
> >  source "fs/cpio/Config.in"
> > -source "fs/iso9660/Config.in"
> >  source "fs/initramfs/Config.in"
> > +source "fs/iso9660/Config.in"
> >  source "fs/romfs/Config.in"
> > +source "fs/squashfs/Config.in"
> > +source "fs/tar/Config.in"
> > +source "fs/ubifs/Config.in"
> 
> Perhaps I misunderstand, but I would have thought cloop should be
> before cramfs,
> jffs2 after iso9660 and cpio before ext2?
> 
> Will
> 
> > 
> >  endmenu
> > --
> > 1.7.10.4
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot@busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> 
> 
>

Patch

diff --git a/fs/Config.in b/fs/Config.in
index 94154ea..e970075 100644
--- a/fs/Config.in
+++ b/fs/Config.in
@@ -4,12 +4,12 @@  source "fs/cramfs/Config.in"
 source "fs/cloop/Config.in"
 source "fs/ext2/Config.in"
 source "fs/jffs2/Config.in"
-source "fs/ubifs/Config.in"
-source "fs/squashfs/Config.in"
-source "fs/tar/Config.in"
 source "fs/cpio/Config.in"
-source "fs/iso9660/Config.in"
 source "fs/initramfs/Config.in"
+source "fs/iso9660/Config.in"
 source "fs/romfs/Config.in"
+source "fs/squashfs/Config.in"
+source "fs/tar/Config.in"
+source "fs/ubifs/Config.in"
 
 endmenu