From patchwork Fri Nov 30 06:41:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guo Chao X-Patchwork-Id: 202881 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 25F172C009F for ; Fri, 30 Nov 2012 17:42:08 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756103Ab2K3GmG (ORCPT ); Fri, 30 Nov 2012 01:42:06 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:60818 "EHLO e23smtp08.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756000Ab2K3GmG (ORCPT ); Fri, 30 Nov 2012 01:42:06 -0500 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 30 Nov 2012 16:40:56 +1000 Received: from d23relay05.au.ibm.com (202.81.31.247) by e23smtp08.au.ibm.com (202.81.31.205) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 30 Nov 2012 16:40:44 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qAU6Ux8L35192930 for ; Fri, 30 Nov 2012 17:30:59 +1100 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qAU6foae022795 for ; Fri, 30 Nov 2012 17:41:50 +1100 Received: from yanx.cn.ibm.com (yanx.cn.ibm.com [9.111.44.79]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id qAU6flkO022680; Fri, 30 Nov 2012 17:41:49 +1100 From: Guo Chao To: tytso@mit.edu Cc: linux-ext4@vger.kernel.org Subject: [PATCH 3/4] ext4: remove redundant code in ext4_alloc_inode() Date: Fri, 30 Nov 2012 14:41:45 +0800 Message-Id: <1354257706-6582-3-git-send-email-yan@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1354257706-6582-1-git-send-email-yan@linux.vnet.ibm.com> References: <1354257706-6582-1-git-send-email-yan@linux.vnet.ibm.com> x-cbid: 12113006-5140-0000-0000-00000272DAC0 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org inode_init_always() will initialize inode->i_data.writeback_index anyway, no need to do this in ext4_alloc_inode(). Signed-off-by: Guo Chao Reviewed-by: Lukas Czerner --- fs/ext4/super.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 66a4e20..15d28e3 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -940,7 +940,6 @@ static struct inode *ext4_alloc_inode(struct super_block *sb) return NULL; ei->vfs_inode.i_version = 1; - ei->vfs_inode.i_data.writeback_index = 0; memset(&ei->i_cached_extent, 0, sizeof(struct ext4_ext_cache)); INIT_LIST_HEAD(&ei->i_prealloc_list); spin_lock_init(&ei->i_prealloc_lock);