From patchwork Fri Nov 30 06:41:43 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guo Chao X-Patchwork-Id: 202878 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D31312C007D for ; Fri, 30 Nov 2012 17:41:55 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755931Ab2K3Gly (ORCPT ); Fri, 30 Nov 2012 01:41:54 -0500 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:50073 "EHLO e23smtp01.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893Ab2K3Glx (ORCPT ); Fri, 30 Nov 2012 01:41:53 -0500 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 30 Nov 2012 16:38:21 +1000 Received: from d23relay04.au.ibm.com (202.81.31.246) by e23smtp01.au.ibm.com (202.81.31.207) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 30 Nov 2012 16:38:20 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qAU6V6KT3015108 for ; Fri, 30 Nov 2012 17:31:07 +1100 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qAU6fmiQ022720 for ; Fri, 30 Nov 2012 17:41:48 +1100 Received: from yanx.cn.ibm.com (yanx.cn.ibm.com [9.111.44.79]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id qAU6flkM022680; Fri, 30 Nov 2012 17:41:47 +1100 From: Guo Chao To: tytso@mit.edu Cc: linux-ext4@vger.kernel.org Subject: [PATCH 1/4] ext4: remove unsafe and unnecessary memset() Date: Fri, 30 Nov 2012 14:41:43 +0800 Message-Id: <1354257706-6582-1-git-send-email-yan@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.9.5 x-cbid: 12113006-1618-0000-0000-000002F2CC1A Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org We memset this page before checking whether it's valid. But we need not memset zeroed page at all. Signed-off-by: Guo Chao Reviewed-by: Lukas Czerner --- fs/ext4/super.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index ad6cd8a..66a4e20 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3206,7 +3206,6 @@ int ext4_calculate_overhead(struct super_block *sb) ext4_fsblk_t overhead = 0; char *buf = (char *) get_zeroed_page(GFP_KERNEL); - memset(buf, 0, PAGE_SIZE); if (!buf) return -ENOMEM;