Patchwork [for-1.3] Build system clean generated source files in tests

login
register
mail settings
Submitter Wayne Xia
Date Nov. 29, 2012, 11:12 a.m.
Message ID <1354187535-16803-1-git-send-email-xiawenc@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/202707/
State New
Headers show

Comments

Wayne Xia - Nov. 29, 2012, 11:12 a.m.
Currently .c files generated in ./tests are not deleted in make
clean. This introduce trouble that, once we made tests in source
root directory, we can't do a succesfully build for tests in another
out of tree directory, for that some file may miss the step to be
generated. This patch fix it.

Steps to reproduce:
in root source directory:
1 ./configure --target-list=x86_64-softmmu
2 make check-report-unit.xml
3 make distclean && rm -rf *-linux-user *-softmmu
goto another directory:
4 configure
5 make check-report-unit.xml

Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
---
 tests/Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Wayne Xia - Dec. 4, 2012, 3:28 a.m.
Resent for that 1.3 have been released. I think this problem should
be fixed otherwise out of tree build fails strangely.

>    Currently .c files generated in ./tests are not deleted in make
> clean. This introduce trouble that, once we made tests in source
> root directory, we can't do a succesfully build for tests in another
> out of tree directory, for that some file may miss the step to be
> generated. This patch fix it.
> 
> Steps to reproduce:
> in root source directory:
> 1 ./configure --target-list=x86_64-softmmu
> 2 make check-report-unit.xml
> 3 make distclean && rm -rf *-linux-user *-softmmu
> goto another directory:
> 4 configure
> 5 make check-report-unit.xml
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>   tests/Makefile |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index b60f0fb..2c90138 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -30,6 +30,7 @@ check-qtest-sparc-y = tests/m48t59-test$(EXESUF)
>   check-qtest-sparc64-y = tests/m48t59-test$(EXESUF)
> 
>   GENERATED_HEADERS += tests/test-qapi-types.h tests/test-qapi-visit.h tests/test-qmp-commands.h
> +GENERATED_SOURCES += tests/test-qapi-types.c tests/test-qapi-visit.c tests/test-qmp-marshal.c
> 
>   test-obj-y = tests/check-qint.o tests/check-qstring.o tests/check-qdict.o \
>   	tests/check-qlist.o tests/check-qfloat.o tests/check-qjson.o \
>

Patch

diff --git a/tests/Makefile b/tests/Makefile
index b60f0fb..2c90138 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -30,6 +30,7 @@  check-qtest-sparc-y = tests/m48t59-test$(EXESUF)
 check-qtest-sparc64-y = tests/m48t59-test$(EXESUF)
 
 GENERATED_HEADERS += tests/test-qapi-types.h tests/test-qapi-visit.h tests/test-qmp-commands.h
+GENERATED_SOURCES += tests/test-qapi-types.c tests/test-qapi-visit.c tests/test-qmp-marshal.c
 
 test-obj-y = tests/check-qint.o tests/check-qstring.o tests/check-qdict.o \
 	tests/check-qlist.o tests/check-qfloat.o tests/check-qjson.o \