Patchwork ext4: remove some unused code lines

login
register
mail settings
Submitter Zhiyong Wu
Date Nov. 29, 2012, 10 a.m.
Message ID <1354183200-8628-1-git-send-email-zwu.kernel@gmail.com>
Download mbox | patch
Permalink /patch/202692/
State Superseded
Headers show

Comments

Zhiyong Wu - Nov. 29, 2012, 10 a.m.
From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>

Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
---
 fs/ext4/extents.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Zheng Liu - Dec. 2, 2012, 12:27 p.m.
On Thu, Nov 29, 2012 at 06:00:00PM +0800, zwu.kernel@gmail.com wrote:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>

Please write a commit log to describe this patch, even though it is
quite simple and straightfoward

Otherwise, it looks good to me.

Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>

Regards,
                                                - Zheng

> 
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> ---
>  fs/ext4/extents.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 7011ac9..43ec639 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -2156,7 +2156,6 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
>  		  struct ext4_extent *ex)
>  {
>  	struct ext4_ext_cache *cex;
> -	struct ext4_sb_info *sbi;
>  	int ret = 0;
>  
>  	/*
> @@ -2164,7 +2163,6 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
>  	 */
>  	spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
>  	cex = &EXT4_I(inode)->i_cached_extent;
> -	sbi = EXT4_SB(inode->i_sb);
>  
>  	/* has cache valid data? */
>  	if (cex->ec_len == 0)
> -- 
> 1.7.6.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Zhiyong Wu - Dec. 3, 2012, 2:11 a.m.
On Sun, Dec 2, 2012 at 8:27 PM, Zheng Liu <gnehzuil.liu@gmail.com> wrote:
> On Thu, Nov 29, 2012 at 06:00:00PM +0800, zwu.kernel@gmail.com wrote:
>> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>
> Please write a commit log to describe this patch, even though it is
> quite simple and straightfoward
Good suggestion, thanks.
>
> Otherwise, it looks good to me.
>
> Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
>
> Regards,
>                                                 - Zheng
>
>>
>> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>> ---
>>  fs/ext4/extents.c |    2 --
>>  1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
>> index 7011ac9..43ec639 100644
>> --- a/fs/ext4/extents.c
>> +++ b/fs/ext4/extents.c
>> @@ -2156,7 +2156,6 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
>>                 struct ext4_extent *ex)
>>  {
>>       struct ext4_ext_cache *cex;
>> -     struct ext4_sb_info *sbi;
>>       int ret = 0;
>>
>>       /*
>> @@ -2164,7 +2163,6 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
>>        */
>>       spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
>>       cex = &EXT4_I(inode)->i_cached_extent;
>> -     sbi = EXT4_SB(inode->i_sb);
>>
>>       /* has cache valid data? */
>>       if (cex->ec_len == 0)
>> --
>> 1.7.6.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Theodore Ts'o - Dec. 7, 2012, 12:06 a.m.
On Sun, Dec 02, 2012 at 08:27:26PM +0800, Zheng Liu wrote:
> On Thu, Nov 29, 2012 at 06:00:00PM +0800, zwu.kernel@gmail.com wrote:
> > From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> 
> Please write a commit log to describe this patch, even though it is
> quite simple and straightfoward
> 
> Otherwise, it looks good to me.
> 
> Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>

I've applied this patch with the description:

    ext4: remove unused variable from ext4_ext_in_cache()

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 7011ac9..43ec639 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2156,7 +2156,6 @@  ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
 		  struct ext4_extent *ex)
 {
 	struct ext4_ext_cache *cex;
-	struct ext4_sb_info *sbi;
 	int ret = 0;
 
 	/*
@@ -2164,7 +2163,6 @@  ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
 	 */
 	spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
 	cex = &EXT4_I(inode)->i_cached_extent;
-	sbi = EXT4_SB(inode->i_sb);
 
 	/* has cache valid data? */
 	if (cex->ec_len == 0)