| Message ID | 1354181179-16294-1-git-send-email-shmulik.ladkani@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Shmulik Ladkani <shmulik.ladkani@gmail.com> Date: Thu, 29 Nov 2012 11:26:19 +0200 > + /* > + * If forwarding is enabled, RA are not accepted unless the special > + * hybrid mode (accept_ra=2) is enabled. > + */ Please format this comment correctly, in the networking we use the style: /* That looks * like this. */ /* * Not * like this. */ Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Fri, 30 Nov 2012 12:09:43 -0500 (EST) David Miller <davem@davemloft.net> wrote: > From: Shmulik Ladkani <shmulik.ladkani@gmail.com> > Date: Thu, 29 Nov 2012 11:26:19 +0200 > > > + /* > > + * If forwarding is enabled, RA are not accepted unless the special > > + * hybrid mode (accept_ra=2) is enabled. > > + */ > > Please format this comment correctly, in the networking we use > the style: > > /* That looks > * like this. > */ > > /* > * Not > * like this. > */ > > Thanks. Ok. Will amend shortly. BTW the "Not like this" style has many occurrences in net/ipv6. One of which was the comment relocated by my patch :-) Regards, Shmulik -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Shmulik Ladkani <shmulik.ladkani@gmail.com> Date: Fri, 30 Nov 2012 21:51:13 +0200 > BTW the "Not like this" style has many occurrences in net/ipv6. > One of which was the comment relocated by my patch :-) Patches to fix this are more than welcome :-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/net/ipv6.h b/include/net/ipv6.h index 979bf6c..cd15585 100644 --- a/include/net/ipv6.h +++ b/include/net/ipv6.h @@ -271,6 +271,16 @@ struct ipv6_txoptions *ipv6_fixup_options(struct ipv6_txoptions *opt_space, extern bool ipv6_opt_accepted(const struct sock *sk, const struct sk_buff *skb); +static inline bool ipv6_accept_ra(struct inet6_dev *idev) +{ + /* + * If forwarding is enabled, RA are not accepted unless the special + * hybrid mode (accept_ra=2) is enabled. + */ + return idev->cnf.forwarding ? idev->cnf.accept_ra == 2 : + idev->cnf.accept_ra; +} + #if IS_ENABLED(CONFIG_IPV6) static inline int ip6_frag_nqueues(struct net *net) { diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 0424e4e..ca1ed8a 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -3005,8 +3005,7 @@ static void addrconf_dad_completed(struct inet6_ifaddr *ifp) router advertisements, start sending router solicitations. */ - if (((ifp->idev->cnf.accept_ra == 1 && !ifp->idev->cnf.forwarding) || - ifp->idev->cnf.accept_ra == 2) && + if (ipv6_accept_ra(ifp->idev) && ifp->idev->cnf.rtr_solicits > 0 && (dev->flags&IFF_LOOPBACK) == 0 && (ipv6_addr_type(&ifp->addr) & IPV6_ADDR_LINKLOCAL)) { diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index 2edce30..980cdc3 100644 --- a/net/ipv6/ndisc.c +++ b/net/ipv6/ndisc.c @@ -1033,18 +1033,6 @@ errout: rtnl_set_sk_err(net, RTNLGRP_ND_USEROPT, err); } -static inline int accept_ra(struct inet6_dev *in6_dev) -{ - /* - * If forwarding is enabled, RA are not accepted unless the special - * hybrid mode (accept_ra=2) is enabled. - */ - if (in6_dev->cnf.forwarding && in6_dev->cnf.accept_ra < 2) - return 0; - - return in6_dev->cnf.accept_ra; -} - static void ndisc_router_discovery(struct sk_buff *skb) { struct ra_msg *ra_msg = (struct ra_msg *)skb_transport_header(skb); @@ -1092,7 +1080,7 @@ static void ndisc_router_discovery(struct sk_buff *skb) return; } - if (!accept_ra(in6_dev)) + if (!ipv6_accept_ra(in6_dev)) goto skip_linkparms; #ifdef CONFIG_IPV6_NDISC_NODETYPE @@ -1248,7 +1236,7 @@ skip_linkparms: NEIGH_UPDATE_F_ISROUTER); } - if (!accept_ra(in6_dev)) + if (!ipv6_accept_ra(in6_dev)) goto out; #ifdef CONFIG_IPV6_ROUTE_INFO
As of 026359b [ipv6: Send ICMPv6 RSes only when RAs are accepted], the logic determining whether to send Router Solicitations is identical to the logic determining whether kernel accepts Router Advertisements. However the condition itself is repeated in several code locations. Unify it by introducing 'ipv6_accept_ra()' accessor. Also, simplify the condition expression, making it more readable. No semantic change. Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com> --- Not sure about the proper header to place the 'ipv6_accept_ra' accessor. Currently placed in include/net/ipv6.h. Other candidates were if_inet6.h and addrconf.h. include/net/ipv6.h | 10 ++++++++++ net/ipv6/addrconf.c | 3 +-- net/ipv6/ndisc.c | 16 ++-------------- 3 files changed, 13 insertions(+), 16 deletions(-)