Patchwork [1/2] data: klog.json: fix up the RSDP error exception advice to make more sense

login
register
mail settings
Submitter Colin King
Date Nov. 28, 2012, 6:35 p.m.
Message ID <1354127750-31428-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/202522/
State Accepted
Headers show

Comments

Colin King - Nov. 28, 2012, 6:35 p.m.
From: Colin Ian King <colin.king@canonical.com>

Reduce the RSDP error to make it simpler to match and also re-word the
advice to make a little more sense.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Alex Hung - Nov. 29, 2012, 12:34 a.m.
On 11/29/2012 02:35 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Reduce the RSDP error to make it simpler to match and also re-word the
> advice to make a little more sense.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index 636d553..19da49f 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2185,8 +2185,8 @@
>      "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_CRITICAL",
>      "tag": "FWTS_TAG_ACPI_RSDP",
> -   "pattern": "ACPI Error.*A valid RSDP was not found",
> -   "advice": "An ACPI-compatible system must provide an RSDP (Root System Description Pointer in the system's low address space. This structure’s only purpose is to provide the physical address of the RSDT and XSDT.",
> +   "pattern": "A valid RSDP was not found",
> +   "advice": "An ACPI compatible system must provide an RSDP (Root System Description Pointer). This structure provides the physical address of the RSDT and XSDT. Since this could not be found, the ACPI driver has had to disable ACPI support.",
>      "label": "KlogAcpiValidRsdpNotFound"
>     },
>     {
>
Acked-by: Alex Hung <alex.hung@canonical.com>
Keng-Yu Lin - Nov. 29, 2012, 5:42 a.m.
On Thu, Nov 29, 2012 at 2:35 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Reduce the RSDP error to make it simpler to match and also re-word the
> advice to make a little more sense.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index 636d553..19da49f 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2185,8 +2185,8 @@
>     "compare_mode": "regex",
>     "log_level": "LOG_LEVEL_CRITICAL",
>     "tag": "FWTS_TAG_ACPI_RSDP",
> -   "pattern": "ACPI Error.*A valid RSDP was not found",
> -   "advice": "An ACPI-compatible system must provide an RSDP (Root System Description Pointer in the system's low address space. This structure’s only purpose is to provide the physical address of the RSDT and XSDT.",
> +   "pattern": "A valid RSDP was not found",
> +   "advice": "An ACPI compatible system must provide an RSDP (Root System Description Pointer). This structure provides the physical address of the RSDT and XSDT. Since this could not be found, the ACPI driver has had to disable ACPI support.",
>     "label": "KlogAcpiValidRsdpNotFound"
>    },
>    {
> --
> 1.8.0
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index 636d553..19da49f 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -2185,8 +2185,8 @@ 
    "compare_mode": "regex",
    "log_level": "LOG_LEVEL_CRITICAL",
    "tag": "FWTS_TAG_ACPI_RSDP",
-   "pattern": "ACPI Error.*A valid RSDP was not found",
-   "advice": "An ACPI-compatible system must provide an RSDP (Root System Description Pointer in the system's low address space. This structure’s only purpose is to provide the physical address of the RSDT and XSDT.",
+   "pattern": "A valid RSDP was not found",
+   "advice": "An ACPI compatible system must provide an RSDP (Root System Description Pointer). This structure provides the physical address of the RSDT and XSDT. Since this could not be found, the ACPI driver has had to disable ACPI support.",
    "label": "KlogAcpiValidRsdpNotFound"
   },
   {