From patchwork Wed Nov 28 18:10:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 202521 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 85DBD2C0086 for ; Thu, 29 Nov 2012 05:10:44 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1354731045; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Received:Date:Message-ID:Subject:From:To: Cc:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=0U5txs7 sS8xTcFcoQdd9cnwMRZw=; b=KM72dRLmCqTtdda9D9nF2wJ5IHR+7+4TYmg+5AS hDQGVXTUrPmBn2bYfs5idtJ5RWvF0LU9VzUdQmIkMaPvyYRp4Y9YIKLCw2+seTCn u7NCBY0iDB1HfZTc1OmvGPFrgnDG0R4N0k0VtHI8M6a+Uf5JBdnhY7tmN7g1j7i4 dZhM= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:MIME-Version:Received:Received:Date:Message-ID:Subject:From:To:Cc:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=erEuVfO7Qhjb0N3s9WJaa0Bbq0c6rW78Y6Ej65DQ+PYDp4D5+T6MRsjtXos8ab EldSqcawk6LKPWa4TFiwrYQRwDZQ/RKgpF6S43F9k2tPIuVhMVqQroti9OPj6pg8 ayI9rju5XlBz2ljfbN7Wv05lG/VjeYIGNZcjyCbQUaymk=; Received: (qmail 32495 invoked by alias); 28 Nov 2012 18:10:39 -0000 Received: (qmail 32483 invoked by uid 22791); 28 Nov 2012 18:10:36 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, TW_ZJ X-Spam-Check-By: sourceware.org Received: from mail-pa0-f47.google.com (HELO mail-pa0-f47.google.com) (209.85.220.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Nov 2012 18:10:32 +0000 Received: by mail-pa0-f47.google.com with SMTP id fa10so4414758pad.20 for ; Wed, 28 Nov 2012 10:10:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.66.77.74 with SMTP id q10mr54155927paw.81.1354126232060; Wed, 28 Nov 2012 10:10:32 -0800 (PST) Received: by 10.66.246.232 with HTTP; Wed, 28 Nov 2012 10:10:31 -0800 (PST) Date: Wed, 28 Nov 2012 19:10:31 +0100 Message-ID: Subject: Re: patch to fix PR55458 From: Uros Bizjak To: gcc-patches@gcc.gnu.org Cc: Vladimir Makarov Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hello! > The following patch fixes > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55458 > > The patch was successfully bootstrapped and tested on x86/x86-64. > > Committed as rev. 193871. > > 2012-11-27 Vladimir Makarov > > PR rtl-optimization/55458 > * lra-assigns.c: Include rtl-error.h. > (assign_by_spills): Report about asm impossible constraints. > * Makefile.in (lra-assigns.c): Add $(RTL_ERROR_H). > > > 2012-11-27 Vladimir Makarov > > PR rtl-optimization/55458 > * gcc.target/i386/pr55458.c: New test. Index: testsuite/gcc.target/i386/pr55458.c =================================================================== --- testsuite/gcc.target/i386/pr55458.c (revision 0) +++ testsuite/gcc.target/i386/pr55458.c (working copy) @@ -0,0 +1,11 @@ +/* { dg-do compile } */ +/* { dg-require-effective-target ilp32 } */ Effective target should be ia32 in this case. x32 also matches ilp32, and since it has plenty of registers, doesn't error-out as expected. Fixed by attached patch. 2012-11-28 Uros Bizjak * gcc.target/i386/pr55458.c: Require ia32 target instead of ilp32. Tested on x86_64-pc-linux-gnu and committed to mainline SVN. Uros. Index: gcc.target/i386/pr55458.c =================================================================== --- gcc.target/i386/pr55458.c (revision 193894) +++ gcc.target/i386/pr55458.c (working copy) @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-require-effective-target ilp32 } */ +/* { dg-require-effective-target ia32 } */ /* { dg-options "-fPIC" } */ int a, b, c;