Patchwork [net] team: fix hw_features setup

login
register
mail settings
Submitter Jiri Pirko
Date Nov. 28, 2012, 4:13 p.m.
Message ID <1354119190-16100-1-git-send-email-jiri@resnulli.us>
Download mbox | patch
Permalink /patch/202502/
State Accepted
Delegated to: David Miller
Headers show

Comments

Jiri Pirko - Nov. 28, 2012, 4:13 p.m.
Do this in the same way bonding does. This fixed setup resolves performance
issues when using some cards with certain offloading.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
 drivers/net/team/team.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
David Miller - Nov. 28, 2012, 4:48 p.m.
From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 28 Nov 2012 17:13:10 +0100

> Do this in the same way bonding does. This fixed setup resolves performance
> issues when using some cards with certain offloading.
> 
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index d44cca3..ad86660 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -1794,10 +1794,12 @@  static void team_setup(struct net_device *dev)
 
 	dev->features |= NETIF_F_LLTX;
 	dev->features |= NETIF_F_GRO;
-	dev->hw_features = NETIF_F_HW_VLAN_TX |
+	dev->hw_features = TEAM_VLAN_FEATURES |
+			   NETIF_F_HW_VLAN_TX |
 			   NETIF_F_HW_VLAN_RX |
 			   NETIF_F_HW_VLAN_FILTER;
 
+	dev->hw_features &= ~(NETIF_F_ALL_CSUM & ~NETIF_F_HW_CSUM);
 	dev->features |= dev->hw_features;
 }