Patchwork [2/2] nbd-server-add: Fix the default for 'writable'

login
register
mail settings
Submitter Paolo Bonzini
Date Nov. 28, 2012, 3:30 p.m.
Message ID <1354116604-32298-3-git-send-email-pbonzini@redhat.com>
Download mbox | patch
Permalink /patch/202482/
State New
Headers show

Comments

Paolo Bonzini - Nov. 28, 2012, 3:30 p.m.
From: Michal Privoznik <mprivozn@redhat.com>

The documentation to this monitor command tells, that 'writable'
argument is optional and defaults to false. However, the code sets
true as the default. But since some applications may already been
using this, it's safer to fix the code and not documentation which
would break those applications.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 blockdev-nbd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/blockdev-nbd.c b/blockdev-nbd.c
index d1721a3..6b26bbf 100644
--- a/blockdev-nbd.c
+++ b/blockdev-nbd.c
@@ -99,7 +99,7 @@  void qmp_nbd_server_add(const char *device, bool has_writable, bool writable,
     }
 
     if (!has_writable) {
-        writable = true;
+        writable = false;
     }
     if (bdrv_is_read_only(bs)) {
         writable = false;