From patchwork Wed Nov 28 15:21:46 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/5] iscsi: fix segfault in url parsing Date: Wed, 28 Nov 2012 05:21:46 -0000 From: Paolo Bonzini X-Patchwork-Id: 202477 Message-Id: <1354116110-28651-2-git-send-email-pbonzini@redhat.com> To: qemu-devel@nongnu.org Cc: Peter Lieven , aliguori@us.ibm.com, Peter Lieven From: Peter Lieven If an invalid URL is specified iscsi_get_error(iscsi) is called with iscsi == NULL. Signed-off-by: Peter Lieven Signed-off-by: Paolo Bonzini --- block/iscsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index a6a819d..5cd8b49 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -947,8 +947,7 @@ static int iscsi_open(BlockDriverState *bs, const char *filename, int flags) iscsi_url = iscsi_parse_full_url(iscsi, filename); if (iscsi_url == NULL) { - error_report("Failed to parse URL : %s %s", filename, - iscsi_get_error(iscsi)); + error_report("Failed to parse URL : %s", filename); ret = -EINVAL; goto out; }