Patchwork [1/5] iscsi: fix segfault in url parsing

login
register
mail settings
Submitter Paolo Bonzini
Date Nov. 28, 2012, 3:21 p.m.
Message ID <1354116110-28651-2-git-send-email-pbonzini@redhat.com>
Download mbox | patch
Permalink /patch/202477/
State New
Headers show

Comments

Paolo Bonzini - Nov. 28, 2012, 3:21 p.m.
From: Peter Lieven <pl@dlhnet.de>

If an invalid URL is specified iscsi_get_error(iscsi) is called
with iscsi == NULL.

Signed-off-by: Peter Lieven <pl@kamp.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 block/iscsi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Patch

diff --git a/block/iscsi.c b/block/iscsi.c
index a6a819d..5cd8b49 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -947,8 +947,7 @@  static int iscsi_open(BlockDriverState *bs, const char *filename, int flags)
 
     iscsi_url = iscsi_parse_full_url(iscsi, filename);
     if (iscsi_url == NULL) {
-        error_report("Failed to parse URL : %s %s", filename,
-                     iscsi_get_error(iscsi));
+        error_report("Failed to parse URL : %s", filename);
         ret = -EINVAL;
         goto out;
     }