Patchwork [U-Boot,2/7,V2] EXYNOS5: FDT: Add sound device node data

login
register
mail settings
Submitter Rajeshwari Birje
Date Nov. 28, 2012, 6:10 a.m.
Message ID <1354083013-5213-3-git-send-email-rajeshwari.s@samsung.com>
Download mbox | patch
Permalink /patch/202368/
State Superseded
Headers show

Comments

Rajeshwari Birje - Nov. 28, 2012, 6:10 a.m.
Add sound device node data for exynos

Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
---
Changes in V2:
        - Added documentation to sound node.
 arch/arm/dts/exynos5250.dtsi              |    5 +++++
 doc/device-tree-bindings/exynos/sound.txt |   27 +++++++++++++++++++++++++++
 2 files changed, 32 insertions(+), 0 deletions(-)
 create mode 100644 doc/device-tree-bindings/exynos/sound.txt
Simon Glass - Nov. 28, 2012, 11:19 p.m.
On Tue, Nov 27, 2012 at 10:10 PM, Rajeshwari Shinde
<rajeshwari.s@samsung.com> wrote:
> Add sound device node data for exynos
>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>

Acked-by: Simon Glass <sjg@chromium.org>

(see comment below)

> ---
> Changes in V2:
>         - Added documentation to sound node.
>  arch/arm/dts/exynos5250.dtsi              |    5 +++++
>  doc/device-tree-bindings/exynos/sound.txt |   27 +++++++++++++++++++++++++++
>  2 files changed, 32 insertions(+), 0 deletions(-)
>  create mode 100644 doc/device-tree-bindings/exynos/sound.txt
>
> diff --git a/arch/arm/dts/exynos5250.dtsi b/arch/arm/dts/exynos5250.dtsi
> index e877e6c..3f750f0 100644
> --- a/arch/arm/dts/exynos5250.dtsi
> +++ b/arch/arm/dts/exynos5250.dtsi
> @@ -97,4 +97,9 @@
>                 reg = <0x12CD0000 0x100>;
>                 interrupts = <0 63 0>;
>         };
> +
> +       sound@12d60000 {
> +               compatible = "samsung,exynos-sound";
> +               reg = <0x12d60000 0x20>;
> +       };
>  };
> diff --git a/doc/device-tree-bindings/exynos/sound.txt b/doc/device-tree-bindings/exynos/sound.txt
> new file mode 100644
> index 0000000..98d1798
> --- /dev/null
> +++ b/doc/device-tree-bindings/exynos/sound.txt
> @@ -0,0 +1,27 @@
> +Exynos Sound Subsystem
> +
> +The device node for sound subsytem which contains codec and i2s block
> +that is a part of Exynos5250
> +
> +Required properties :
> + - compatible : Should be "samsung,exynos-sound" for sound
> + - samsung,i2s-epll-clock-frequency : epll clock output frequency in Hz
> + - samsung,i2s-sampling-rate : sampling rate, default is 48000
> + - samsung,i2s-bits-per-sample : sample width, defalut is 16 bit
> + - samsung,i2s-channels : nummber of channels, default is 2
> + - samsung,i2s-lr-clk-framesize : lr clock frame size
> + - samsung,i2s-bit-clk-framesize : bit clock frame size
> + - samsung,codec-type : sound codec type
> +
> +Example:
> +
> +sound@12d60000 {
> +       compatible = "samsung,exynos-sound"
> +       samsung,i2s-epll-clock-frequency = <192000000>;
> +       samsung,i2s-sampling-rate = <48000>;
> +       samsung,i2s-bits-per-sample = <16>;
> +       samsung,i2s-channels = <2>;
> +       samsung,i2s-lr-clk-framesize = <256>;
> +       samsung,i2s-bit-clk-framesize = <32>;
> +       samsung,codec-type = "wm8994";

Strictly speaking this should not be needed, but you use it as a way
to call your driver, which is reasonable until we have device model,
so this is fine I think.

> +};
> --
> 1.7.4.4
>

Regards,
Simon

Patch

diff --git a/arch/arm/dts/exynos5250.dtsi b/arch/arm/dts/exynos5250.dtsi
index e877e6c..3f750f0 100644
--- a/arch/arm/dts/exynos5250.dtsi
+++ b/arch/arm/dts/exynos5250.dtsi
@@ -97,4 +97,9 @@ 
 		reg = <0x12CD0000 0x100>;
 		interrupts = <0 63 0>;
 	};
+
+	sound@12d60000 {
+		compatible = "samsung,exynos-sound";
+		reg = <0x12d60000 0x20>;
+	};
 };
diff --git a/doc/device-tree-bindings/exynos/sound.txt b/doc/device-tree-bindings/exynos/sound.txt
new file mode 100644
index 0000000..98d1798
--- /dev/null
+++ b/doc/device-tree-bindings/exynos/sound.txt
@@ -0,0 +1,27 @@ 
+Exynos Sound Subsystem
+
+The device node for sound subsytem which contains codec and i2s block
+that is a part of Exynos5250
+
+Required properties :
+ - compatible : Should be "samsung,exynos-sound" for sound
+ - samsung,i2s-epll-clock-frequency : epll clock output frequency in Hz
+ - samsung,i2s-sampling-rate : sampling rate, default is 48000
+ - samsung,i2s-bits-per-sample : sample width, defalut is 16 bit
+ - samsung,i2s-channels : nummber of channels, default is 2
+ - samsung,i2s-lr-clk-framesize : lr clock frame size
+ - samsung,i2s-bit-clk-framesize : bit clock frame size
+ - samsung,codec-type : sound codec type
+
+Example:
+
+sound@12d60000 {
+	compatible = "samsung,exynos-sound"
+	samsung,i2s-epll-clock-frequency = <192000000>;
+	samsung,i2s-sampling-rate = <48000>;
+	samsung,i2s-bits-per-sample = <16>;
+	samsung,i2s-channels = <2>;
+	samsung,i2s-lr-clk-framesize = <256>;
+	samsung,i2s-bit-clk-framesize = <32>;
+	samsung,codec-type = "wm8994";
+};