Patchwork e2fsprogs: fix configure help text for quota

login
register
mail settings
Submitter Eric Sandeen
Date Nov. 27, 2012, 6:21 p.m.
Message ID <50B504C4.6090504@redhat.com>
Download mbox | patch
Permalink /patch/202270/
State Accepted
Headers show

Comments

Eric Sandeen - Nov. 27, 2012, 6:21 p.m.
It's --enable-quota, not --enable-libquota.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

PS it's still off by default.  Should it be?  What bugs remain?

Manpage refers to "-O quota" unconditionally.  Maybe that should be
different depending on how it's configured?





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Theodore Ts'o - Nov. 29, 2012, 4:03 a.m.
On Tue, Nov 27, 2012 at 12:21:56PM -0600, Eric Sandeen wrote:
> It's --enable-quota, not --enable-libquota.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Thanks, applied.

> PS it's still off by default.  Should it be?  What bugs remain?

Yeah, we probably should turn it on.  It's turned on by default in
Debian in the 1.42.x releases.  I don't know of any remaining bugs,
but at the same time, it's not gotten a lot of use to date.

       	   	      	       	      - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Eric Sandeen - Nov. 29, 2012, 5:50 a.m.
On 11/28/12 10:03 PM, Theodore Ts'o wrote:
> On Tue, Nov 27, 2012 at 12:21:56PM -0600, Eric Sandeen wrote:
>> It's --enable-quota, not --enable-libquota.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> 
> Thanks, applied.
> 
>> PS it's still off by default.  Should it be?  What bugs remain?
> 
> Yeah, we probably should turn it on.  It's turned on by default in
> Debian in the 1.42.x releases.  I don't know of any remaining bugs,
> but at the same time, it's not gotten a lot of use to date.
> 
>        	   	      	       	      - Ted

Hum, ok.

Maybe then rather than fixing up all the configure stuff, I
should have just removed the switch and turned it on.  Oh well.

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Theodore Ts'o - Nov. 29, 2012, 1:55 p.m.
On Wed, Nov 28, 2012 at 11:50:46PM -0600, Eric Sandeen wrote:
> 
> Maybe then rather than fixing up all the configure stuff, I
> should have just removed the switch and turned it on.  Oh well.

I applied the fix to the maint branch (1.42.x).  Yeah, we should
probably remove the switch from the master/next branches.  Also on my
todo list is to rename libquota to something like libinternal, and
then move things like e2fsck/profile.c to libinternal (since we
currently share that code in mke2fs via a pretty ugly ad hoc
mechanisms, and having a static libinternal library would be a cleaner
way of handling things).

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/configure b/configure
index d47cef7..91e2bf5 100755
--- a/configure
+++ b/configure
@@ -1498,7 +1498,7 @@  Optional Features:
   --disable-testio-debug  disable the use of the test I/O manager for debugging
   --disable-libuuid	  do not build private uuid library
   --disable-libblkid	  do not build private blkid library
-  --enable-libquota	  enable quota support
+  --enable-quota	  enable quota support
   --disable-debugfs   	  disable support of debugfs program
   --disable-imager   	  disable support of e2image program
   --disable-resizer   	  disable support of e2resize program
diff --git a/configure.in b/configure.in
index 0b96b8d..bc8d1e8 100644
--- a/configure.in
+++ b/configure.in
@@ -568,7 +568,7 @@  dnl
 PKG_PROG_PKG_CONFIG
 AH_TEMPLATE([CONFIG_QUOTA], [Define to 1 to enable quota support])
 AC_ARG_ENABLE([quota],
-[  --enable-libquota	  enable quota support],
+[  --enable-quota	  enable quota support],
 if test "$enableval" = "no"
 then
 	AC_MSG_RESULT([Disabling quota support])