Patchwork [U-Boot,9/9] Add DFU config

login
register
mail settings
Submitter Pantelis Antoniou
Date Nov. 28, 2012, 12:44 p.m.
Message ID <1354106642-4587-10-git-send-email-panto@antoniou-consulting.com>
Download mbox | patch
Permalink /patch/202246/
State Superseded
Delegated to: Marek Vasut
Headers show

Comments

Marek Vasut - Nov. 28, 2012, 2:52 a.m.
Dear Pantelis Antoniou,

> Add configuration for using DFU on the am335x_evm boards
> 
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> ---
>  include/configs/am335x_evm.h | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h
> index ab9549b..0befa34 100644
> --- a/include/configs/am335x_evm.h
> +++ b/include/configs/am335x_evm.h
> @@ -39,6 +39,8 @@
>  #define CONFIG_SETUP_MEMORY_TAGS
>  #define CONFIG_INITRD_TAG
> 
> +#define CONFIG_SYS_CACHELINE_SIZE       64

How come you need this, isn't it configured by default for ARM ?

>  /* commands to include */
>  #include <config_cmd_default.h>
> 
> @@ -90,6 +92,7 @@
>  			"setenv fdtfile am335x-evm.dtb; fi; " \
>  		"if test $board_name = A335X_SK; then " \
>  			"setenv fdtfile am335x-evmsk.dtb; fi\0" \
> +	CONFIG_DFU_ALT

What's this stuff here?

>  #define CONFIG_BOOTCOMMAND \
>  	"mmc dev ${mmcdev}; if mmc rescan; then " \
> @@ -153,6 +156,28 @@
>  #define CONFIG_CMD_SF
>  #define CONFIG_SF_DEFAULT_SPEED		(24000000)
> 
> +/* USB Composite download gadget - g_dnl */
> +#define CONFIG_USB_GADGET
> +#define CONFIG_USBDOWNLOAD_GADGET
> +#define CONFIG_DFU_FUNCTION
> +#define CONFIG_DFU_MMC
> +
> +/* USB TI's IDs */
> +#define CONFIG_USBD_HS
> +#define CONFIG_G_DNL_VENDOR_NUM 0x0525
> +#define CONFIG_G_DNL_PRODUCT_NUM 0xa4a7
> +#define CONFIG_G_DNL_MANUFACTURER "Texas Instruments"
> +
> +#define CONFIG_DFU_ALT \
> +	"dfu_alt_info=" \
> +	"boot part 0 1;" \
> +	"rootfs part 0 2;" \
> +	"MLO fat 0 1;" \
> +	"u-boot.img fat 0 1;" \
> +	"uEnv.txt fat 0 1\0"
> +
> +#define CONFIG_CMD_DFU

I see ... hm. Not my call to decide.

>   /* Physical Memory Map */
>  #define CONFIG_NR_DRAM_BANKS		1		/*  1 bank of DRAM */
>  #define PHYS_DRAM_1			0x80000000	/* DRAM Bank #1 */
> @@ -265,6 +290,7 @@
>  #define CONFIG_MUSB_GADGET
>  #define CONFIG_MUSB_PIO_ONLY
>  #define CONFIG_USB_GADGET_DUALSPEED
> +#define CONFIG_USB_GADGET_VBUS_DRAW	2
>  #define CONFIG_MUSB_HOST
>  #define CONFIG_AM335X_USB0
>  #define CONFIG_AM335X_USB0_MODE	MUSB_PERIPHERAL

Best regards,
Marek Vasut
Tom Rini - Nov. 28, 2012, 3:04 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/27/12 21:52, Marek Vasut wrote:
> Dear Pantelis Antoniou,
> 
>> Add configuration for using DFU on the am335x_evm boards
>> 
>> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com> 
>> --- include/configs/am335x_evm.h | 26 ++++++++++++++++++++++++++ 
>> 1 file changed, 26 insertions(+)
>> 
>> diff --git a/include/configs/am335x_evm.h
>> b/include/configs/am335x_evm.h index ab9549b..0befa34 100644 ---
>> a/include/configs/am335x_evm.h +++
>> b/include/configs/am335x_evm.h @@ -39,6 +39,8 @@ #define
>> CONFIG_SETUP_MEMORY_TAGS #define CONFIG_INITRD_TAG
>> 
>> +#define CONFIG_SYS_CACHELINE_SIZE       64
> 
> How come you need this, isn't it configured by default for ARM ?

iirc if we don't spell it out, it's 32, which isn't correct for the
platform.  It should be a separate patch however.

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQIcBAEBAgAGBQJQtX9UAAoJENk4IS6UOR1WVdUP/1RbqCpgmttzpUqYDwKkVA76
b+m6Wbo5fqzle4mKy8sKBjVZCYARdtp3VPLxcqfyY5ZjZQIezjQre7PWdPWFJiDf
Yg/LoajSBxDJ2yRCgJQ4suP5lGE5lG7T0xMXE6ulIB/A4WshLJPW9IxVZT2p4iHu
93NfAY6DbKFxIze8jCJnXis8MYiAe8WCKkWmAhKt07N9Fw7L4iJcryisuG//53sq
GLdxYuIsa76h+oi3D1nPOLLp1Jldp5BbtwHW9IVPHcYC6bPFebh8juRlzPJFxqPT
FpUA4d1+dF95/MBAUSN7eewxs6Ic2Y6rpK7pYAUs3IXBDq9X9nCm1dyslo7nTKpv
K5ARuQ2OzcqD7ZfeeSyVmWHQ9RzXLbepVcWWpjv0bgumgtujrQoPB+tgnIpeObf8
R9E2XPwCO9gOjUVVudGTZ/FcNS61vwacJhVRsQvjv4Ba6ZOC5Z/bjvKqkwKA9JP4
wY+jLvjeWJOo6ZZ4/CPeO48+i6ZYbipPEj+0YQ2yL2madKYlopNG//esLZ3g7koE
ptb5nbzc0dObuAwtoqGYXIBS+i1HhsQ5c4fLOOKM69FRExC1QAoQf2KF7nbvr7RU
oL28no8EIPF5QfrneK+4HapgYfdLslqlfsrqiSqnHATWAxroddTSNii/j8n2UfA0
YXlUFd7+msYT6qVdZ9dR
=QzXg
-----END PGP SIGNATURE-----
Pantelis Antoniou - Nov. 28, 2012, 8:32 a.m.
On Nov 28, 2012, at 5:04 AM, Tom Rini wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 11/27/12 21:52, Marek Vasut wrote:
>> Dear Pantelis Antoniou,
>> 
>>> Add configuration for using DFU on the am335x_evm boards
>>> 
>>> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com> 
>>> --- include/configs/am335x_evm.h | 26 ++++++++++++++++++++++++++ 
>>> 1 file changed, 26 insertions(+)
>>> 
>>> diff --git a/include/configs/am335x_evm.h
>>> b/include/configs/am335x_evm.h index ab9549b..0befa34 100644 ---
>>> a/include/configs/am335x_evm.h +++
>>> b/include/configs/am335x_evm.h @@ -39,6 +39,8 @@ #define
>>> CONFIG_SETUP_MEMORY_TAGS #define CONFIG_INITRD_TAG
>>> 
>>> +#define CONFIG_SYS_CACHELINE_SIZE       64
>> 
>> How come you need this, isn't it configured by default for ARM ?
> 
> iirc if we don't spell it out, it's 32, which isn't correct for the
> platform.  It should be a separate patch however.
> 

OK.

> - -- 
> Tom
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
> 
> iQIcBAEBAgAGBQJQtX9UAAoJENk4IS6UOR1WVdUP/1RbqCpgmttzpUqYDwKkVA76
> b+m6Wbo5fqzle4mKy8sKBjVZCYARdtp3VPLxcqfyY5ZjZQIezjQre7PWdPWFJiDf
> Yg/LoajSBxDJ2yRCgJQ4suP5lGE5lG7T0xMXE6ulIB/A4WshLJPW9IxVZT2p4iHu
> 93NfAY6DbKFxIze8jCJnXis8MYiAe8WCKkWmAhKt07N9Fw7L4iJcryisuG//53sq
> GLdxYuIsa76h+oi3D1nPOLLp1Jldp5BbtwHW9IVPHcYC6bPFebh8juRlzPJFxqPT
> FpUA4d1+dF95/MBAUSN7eewxs6Ic2Y6rpK7pYAUs3IXBDq9X9nCm1dyslo7nTKpv
> K5ARuQ2OzcqD7ZfeeSyVmWHQ9RzXLbepVcWWpjv0bgumgtujrQoPB+tgnIpeObf8
> R9E2XPwCO9gOjUVVudGTZ/FcNS61vwacJhVRsQvjv4Ba6ZOC5Z/bjvKqkwKA9JP4
> wY+jLvjeWJOo6ZZ4/CPeO48+i6ZYbipPEj+0YQ2yL2madKYlopNG//esLZ3g7koE
> ptb5nbzc0dObuAwtoqGYXIBS+i1HhsQ5c4fLOOKM69FRExC1QAoQf2KF7nbvr7RU
> oL28no8EIPF5QfrneK+4HapgYfdLslqlfsrqiSqnHATWAxroddTSNii/j8n2UfA0
> YXlUFd7+msYT6qVdZ9dR
> =QzXg
> -----END PGP SIGNATURE-----
Pantelis Antoniou - Nov. 28, 2012, 12:44 p.m.
Add configuration for using DFU on the am335x_evm boards

Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
---
 include/configs/am335x_evm.h | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

Patch

diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h
index ab9549b..0befa34 100644
--- a/include/configs/am335x_evm.h
+++ b/include/configs/am335x_evm.h
@@ -39,6 +39,8 @@ 
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_INITRD_TAG
 
+#define CONFIG_SYS_CACHELINE_SIZE       64
+
 /* commands to include */
 #include <config_cmd_default.h>
 
@@ -90,6 +92,7 @@ 
 			"setenv fdtfile am335x-evm.dtb; fi; " \
 		"if test $board_name = A335X_SK; then " \
 			"setenv fdtfile am335x-evmsk.dtb; fi\0" \
+	CONFIG_DFU_ALT
 
 #define CONFIG_BOOTCOMMAND \
 	"mmc dev ${mmcdev}; if mmc rescan; then " \
@@ -153,6 +156,28 @@ 
 #define CONFIG_CMD_SF
 #define CONFIG_SF_DEFAULT_SPEED		(24000000)
 
+/* USB Composite download gadget - g_dnl */
+#define CONFIG_USB_GADGET
+#define CONFIG_USBDOWNLOAD_GADGET
+#define CONFIG_DFU_FUNCTION
+#define CONFIG_DFU_MMC
+
+/* USB TI's IDs */
+#define CONFIG_USBD_HS
+#define CONFIG_G_DNL_VENDOR_NUM 0x0525
+#define CONFIG_G_DNL_PRODUCT_NUM 0xa4a7
+#define CONFIG_G_DNL_MANUFACTURER "Texas Instruments"
+
+#define CONFIG_DFU_ALT \
+	"dfu_alt_info=" \
+	"boot part 0 1;" \
+	"rootfs part 0 2;" \
+	"MLO fat 0 1;" \
+	"u-boot.img fat 0 1;" \
+	"uEnv.txt fat 0 1\0"
+
+#define CONFIG_CMD_DFU
+
  /* Physical Memory Map */
 #define CONFIG_NR_DRAM_BANKS		1		/*  1 bank of DRAM */
 #define PHYS_DRAM_1			0x80000000	/* DRAM Bank #1 */
@@ -265,6 +290,7 @@ 
 #define CONFIG_MUSB_GADGET
 #define CONFIG_MUSB_PIO_ONLY
 #define CONFIG_USB_GADGET_DUALSPEED
+#define CONFIG_USB_GADGET_VBUS_DRAW	2
 #define CONFIG_MUSB_HOST
 #define CONFIG_AM335X_USB0
 #define CONFIG_AM335X_USB0_MODE	MUSB_PERIPHERAL