From patchwork Tue Nov 27 08:30:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnout Vandecappelle X-Patchwork-Id: 202115 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id C22F42C0081 for ; Tue, 27 Nov 2012 19:30:33 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5937DA0176; Tue, 27 Nov 2012 08:30:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FiWUiKiPOdvB; Tue, 27 Nov 2012 08:30:25 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id AC910A017A; Tue, 27 Nov 2012 08:30:24 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 0FDD18F783 for ; Tue, 27 Nov 2012 08:30:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 24DC886841 for ; Tue, 27 Nov 2012 08:30:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aNTFX6J7+REB for ; Tue, 27 Nov 2012 08:30:18 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from viper.mind.be (132.79-246-81.adsl-static.isp.belgacom.be [81.246.79.132]) by whitealder.osuosl.org (Postfix) with ESMTPS id B6AE686827 for ; Tue, 27 Nov 2012 08:30:17 +0000 (UTC) Received: from [172.16.2.6] (helo=vandecaa-laptop) by viper.mind.be with esmtp (Exim 4.69) (envelope-from ) id 1TdGYY-0007CA-Gj; Tue, 27 Nov 2012 09:30:14 +0100 Received: from arnout by vandecaa-laptop with local (Exim 4.80) (envelope-from ) id 1TdGYX-0007SS-RI; Tue, 27 Nov 2012 09:30:13 +0100 From: "Arnout Vandecappelle (Essensium/Mind)" To: buildroot@busybox.net Date: Tue, 27 Nov 2012 09:30:12 +0100 Message-Id: <1354005013-28626-3-git-send-email-arnout@mind.be> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1354005013-28626-1-git-send-email-arnout@mind.be> References: <1354005013-28626-1-git-send-email-arnout@mind.be> Subject: [Buildroot] [PATCH for-2012.11 3/4] manual: give example where _INSTALL_TARGET = NO X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net From: "Arnout Vandecappelle (Essensium/Mind)" The tutorial for autotools-package and cmake-package currently gives the bad example of setting _INSTALL_TARGET to YES, which is the default. So change this into an example with _INSTALL_TARGET = NO, and explain in which case this is relevant. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- .topdeps | 2 +- .topmsg | 7 ++++++- docs/manual/adding-packages-autotools.txt | 16 ++++++++-------- docs/manual/adding-packages-cmake.txt | 14 +++++++------- 4 files changed, 22 insertions(+), 17 deletions(-) diff --git a/.topdeps b/.topdeps index d46ee1c..1d0f8a5 100644 --- a/.topdeps +++ b/.topdeps @@ -1 +1 @@ -t/manual +t/manual-target-warning diff --git a/.topmsg b/.topmsg index 367c0df..d1713c4 100644 --- a/.topmsg +++ b/.topmsg @@ -1,4 +1,9 @@ From: Arnout Vandecappelle (Essensium/Mind) -Subject: [PATCH] manual: more warnings to not use output/target +Subject: [PATCH] manual: give example where _INSTALL_TARGET = NO + +The tutorial for autotools-package and cmake-package currently gives +the bad example of setting _INSTALL_TARGET to YES, which is the default. +So change this into an example with _INSTALL_TARGET = NO, and explain in +which case this is relevant. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) diff --git a/docs/manual/adding-packages-autotools.txt b/docs/manual/adding-packages-autotools.txt index 4127df4..84d76f9 100644 --- a/docs/manual/adding-packages-autotools.txt +++ b/docs/manual/adding-packages-autotools.txt @@ -21,8 +21,8 @@ package, with an example : 07: LIBFOO_SOURCE = libfoo-$(LIBFOO_VERSION).tar.gz 08: LIBFOO_SITE = http://www.foosoftware.org/download 09: LIBFOO_INSTALL_STAGING = YES -10: LIBFOO_INSTALL_TARGET = YES -11: LIBFOO_CONF_OPT = --enable-shared +10: LIBFOO_INSTALL_TARGET = NO +11: LIBFOO_CONF_OPT = --disable-shared 12: LIBFOO_DEPENDENCIES = libglib2 host-pkgconf 13: 14: $(eval $(autotools-package)) @@ -44,13 +44,13 @@ other libraries or applications depending on them. Also by default, when staging installation is enabled, packages are installed in this location using the +make install+ command. -On line 10, we tell Buildroot to also install the package to the +On line 10, we tell Buildroot to not install the package to the target directory. This directory contains what will become the root -filesystem running on the target. Usually, we try not to install header -files and to install stripped versions of the binary. By default, target -installation is enabled, so in fact, this line is not strictly -necessary. Also by default, packages are installed in this location -using the +make install+ command. +filesystem running on the target. For purely static libraries, it is +not necessary to install them in the target directory because they will +not be used at runtime. By default, target installation is enabled; setting +this variable to NO is almost never needed. Also by default, packages are +installed in this location using the +make install+ command. On line 11, we tell Buildroot to pass a custom configure option, that will be passed to the +./configure+ script before configuring diff --git a/docs/manual/adding-packages-cmake.txt b/docs/manual/adding-packages-cmake.txt index 4a9e893..bb1705b 100644 --- a/docs/manual/adding-packages-cmake.txt +++ b/docs/manual/adding-packages-cmake.txt @@ -21,7 +21,7 @@ with an example : 07: LIBFOO_SOURCE = libfoo-$(LIBFOO_VERSION).tar.gz 08: LIBFOO_SITE = http://www.foosoftware.org/download 09: LIBFOO_INSTALL_STAGING = YES -10: LIBFOO_INSTALL_TARGET = YES +10: LIBFOO_INSTALL_TARGET = NO 11: LIBFOO_CONF_OPT = -DBUILD_DEMOS=ON 12: LIBFOO_DEPENDENCIES = libglib2 host-pkgconf 13: @@ -44,13 +44,13 @@ other libraries or applications depending on them. Also by default, when staging installation is enabled, packages are installed in this location using the +make install+ command. -On line 10, we tell Buildroot to also install the package to the +On line 10, we tell Buildroot to not install the package to the target directory. This directory contains what will become the root -filesystem running on the target. Usually, we try not to install header -files and to install stripped versions of the binary. By default, target -installation is enabled, so in fact, this line is not strictly -necessary. Also by default, packages are installed in this location -using the +make install+ command. +filesystem running on the target. For purely static libraries, it is +not necessary to install them in the target directory because they will +not be used at runtime. By default, target installation is enabled; setting +this variable to NO is almost never needed. Also by default, packages are +installed in this location using the +make install+ command. On line 11, we tell Buildroot to pass custom options to CMake when it is configuring the package.