Patchwork Fix the bug of comparing goto_locus to UNKNOWN_LOCATION

login
register
mail settings
Submitter Dehao Chen
Date Nov. 26, 2012, 10:47 p.m.
Message ID <CAO2gOZU=_+yquk0vL407KRxnUeu=sFqEsh8k3tvaGTudFaw0kQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/202040/
State New
Headers show

Comments

Dehao Chen - Nov. 26, 2012, 10:47 p.m.
Hi,

This patch fixes a bug of comparing goto_locus to UNKNOWN_LOCATION
when combining basic blocks.

Bootstrapped and and passed gcc regression tests.

Is it okay for trunk?

Thanks,
Dehao

gcc/ChangeLog:
2012-11-26  Dehao Chen  <dehao@google.com>

        * cfgrtl.c (rtl_merge_blocks): Check with UNKNOWN_LOCATION correctly.
        (cfg_layout_merge_blocks): Likewise.
Eric Botcazou - Nov. 27, 2012, 9:18 a.m.
> gcc/ChangeLog:
> 2012-11-26  Dehao Chen  <dehao@google.com>
> 
>        * cfgrtl.c (rtl_merge_blocks): Check with UNKNOWN_LOCATION correctly.
>        (cfg_layout_merge_blocks): Likewise.

OK, thanks.

Patch

Index: gcc/cfgrtl.c
===================================================================
--- gcc/cfgrtl.c (revision 193828)
+++ gcc/cfgrtl.c (working copy)
@@ -890,7 +890,8 @@  rtl_merge_blocks (basic_block a, basic_block b)
   df_bb_delete (b->index);

   /* If B was a forwarder block, propagate the locus on the edge.  */
-  if (forwarder_p && !EDGE_SUCC (b, 0)->goto_locus)
+  if (forwarder_p
+      && LOCATION_LOCUS (EDGE_SUCC (b, 0)->goto_locus) == UNKNOWN_LOCATION)
     EDGE_SUCC (b, 0)->goto_locus = EDGE_SUCC (a, 0)->goto_locus;

   if (dump_file)
@@ -4149,7 +4150,7 @@  cfg_layout_merge_blocks (basic_block a, basic_bloc

   /* If B was a forwarder block, propagate the locus on the edge.  */
   if (forwarder_p
-      && LOCATION_LOCUS (EDGE_SUCC (b, 0)->goto_locus) != UNKNOWN_LOCATION)
+      && LOCATION_LOCUS (EDGE_SUCC (b, 0)->goto_locus) == UNKNOWN_LOCATION)
     EDGE_SUCC (b, 0)->goto_locus = EDGE_SUCC (a, 0)->goto_locus;

   if (dump_file)