From patchwork Mon Nov 26 21:58:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 202038 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 7CD842C0086 for ; Tue, 27 Nov 2012 08:58:58 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1354571939; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Date:From:To:Subject:Message-ID:Reply-To:MIME-Version: Content-Type:Content-Disposition:User-Agent:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=Cep0zlI61Wd9hB1Q95MoMONK2cw=; b=bhG5Q7nIc4Bpw0fT7bSdPwC1pWlBEqunF4VRoUVAvNPPs7snXRc6xc4rJA1fBV 4GZotX6vf2/Fb/u/3R/ChPmyjzBDUVmH4DdWVLqsDtPSXac+zfgRvHgunDqNJsEL Q6gH87sy55/ztHU8dw5FKrcPCTjTlkrT9+ApAQdMZ1NiM= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-ExtLoop1:Received:Received:Date:From:To:Subject:Message-ID:Reply-To:MIME-Version:Content-Type:Content-Disposition:User-Agent:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=gi7HASHi3En3sZJbL+jVdDn/vRZoiF7mGFi9GqS/Ry0qh4AWpT4lf7L1PwPJ5n 2Aq5fewnnvc7b20FBXMZoId5Yiu0AkzAc5X1aX77dIIm6//dNk1p33nNaN/i157s CnLcGWBGDXVV4vRIxNt9yxNibbjAvB8xlGLU6qw9PbmNs=; Received: (qmail 18543 invoked by alias); 26 Nov 2012 21:58:52 -0000 Received: (qmail 18527 invoked by uid 22791); 26 Nov 2012 21:58:51 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, NO_DNS_FOR_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Nov 2012 21:58:46 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 26 Nov 2012 13:58:40 -0800 X-ExtLoop1: 1 Received: from gnu-6.sc.intel.com ([10.3.194.135]) by fmsmga002.fm.intel.com with ESMTP; 26 Nov 2012 13:58:40 -0800 Received: by gnu-6.sc.intel.com (Postfix, from userid 500) id 6302A80740; Mon, 26 Nov 2012 13:58:40 -0800 (PST) Date: Mon, 26 Nov 2012 13:58:40 -0800 From: "H.J. Lu" To: gcc-patches@gcc.gnu.org Subject: PATCH: lto/55474: global-buffer-overflow in lto-wrapper.c Message-ID: <20121126215840.GA30771@intel.com> Reply-To: "H.J. Lu" MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi, OPT_SPECIAL_unknown, OPT_SPECIAL_ignore, OPT_SPECIAL_program_name and OPT_SPECIAL_input_file are special options, which aren't in cl_options. This patch avoids if (!(cl_options[foption->opt_index].flags & CL_TARGET)) on them. This patch skips them. OK to install? Thanks. H.J. --- 2012-11-26 H.J. Lu PR lto/55474 * lto-wrapper.c (merge_and_complain): Handle OPT_SPECIAL_unknown, OPT_SPECIAL_ignore, OPT_SPECIAL_program_name and OPT_SPECIAL_input_file. diff --git a/gcc/lto-wrapper.c b/gcc/lto-wrapper.c index 1f4d212..24de743 100644 --- a/gcc/lto-wrapper.c +++ b/gcc/lto-wrapper.c @@ -393,6 +393,12 @@ merge_and_complain (struct cl_decoded_option **decoded_options, struct cl_decoded_option *foption = &fdecoded_options[i]; switch (foption->opt_index) { + case OPT_SPECIAL_unknown: + case OPT_SPECIAL_ignore: + case OPT_SPECIAL_program_name: + case OPT_SPECIAL_input_file: + break; + default: if (!(cl_options[foption->opt_index].flags & CL_TARGET)) break;