From patchwork Mon Nov 26 19:17:42 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 202014 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D8CA92C0085 for ; Tue, 27 Nov 2012 06:18:06 +1100 (EST) Received: from localhost ([::1]:60759 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Td4Bv-0003RM-6H for incoming@patchwork.ozlabs.org; Mon, 26 Nov 2012 14:18:03 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Td4Bh-0003P8-DK for qemu-devel@nongnu.org; Mon, 26 Nov 2012 14:17:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Td4Bf-0001D0-0y for qemu-devel@nongnu.org; Mon, 26 Nov 2012 14:17:49 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36828 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Td4Be-0001Ci-Qj for qemu-devel@nongnu.org; Mon, 26 Nov 2012 14:17:46 -0500 Received: from relay2.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 126F5A451C; Mon, 26 Nov 2012 20:17:46 +0100 (CET) From: Alexander Graf To: "qemu-devel@nongnu.org qemu-devel" Date: Mon, 26 Nov 2012 20:17:42 +0100 Message-Id: <1353957462-27603-3-git-send-email-agraf@suse.de> X-Mailer: git-send-email 1.6.0.2 In-Reply-To: <1353957462-27603-1-git-send-email-agraf@suse.de> References: <1353957462-27603-1-git-send-email-agraf@suse.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 195.135.220.15 Cc: Blue Swirl , Cornelia Huck , Jens Freimann , Aurelien Jarno , Christian Borntraeger Subject: [Qemu-devel] [PATCH 2/2] sclp: Fix uninitialized var in handle_write_event_buf(). X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Cornelia Huck Some gcc versions rightly complain about a possibly unitialized rc, so let's move setting it before the QTAILQ_FOREACH(). Signed-off-by: Cornelia Huck Signed-off-by: Christian Borntraeger Signed-off-by: Jens Freimann Signed-off-by: Alexander Graf --- hw/s390x/event-facility.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c index 9367660..bc9cea9 100644 --- a/hw/s390x/event-facility.c +++ b/hw/s390x/event-facility.c @@ -112,12 +112,13 @@ static uint16_t handle_write_event_buf(SCLPEventFacility *ef, SCLPEvent *event; SCLPEventClass *ec; + rc = SCLP_RC_INVALID_FUNCTION; + QTAILQ_FOREACH(kid, &ef->sbus.qbus.children, sibling) { DeviceState *qdev = kid->child; event = (SCLPEvent *) qdev; ec = SCLP_EVENT_GET_CLASS(event); - rc = SCLP_RC_INVALID_FUNCTION; if (ec->write_event_data && ec->event_type() == event_buf->type) { rc = ec->write_event_data(event, event_buf);