From patchwork Mon Nov 26 18:55:55 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [4/6] pseries: Fix bug in PCI MSI allocation Date: Mon, 26 Nov 2012 08:55:55 -0000 From: Alexander Graf X-Patchwork-Id: 202011 Message-Id: <1353956157-26879-5-git-send-email-agraf@suse.de> To: "qemu-devel@nongnu.org qemu-devel" Cc: Blue Swirl , Alexey Kardashevskiy , "qemu-ppc@nongnu.org List" , Aurelien Jarno , David Gibson From: Alexey Kardashevskiy In one of the recent reworks to the XICS code, a bug was introduced where we use the wrong sense and allocate level interrupts instead of message interrupts for PCI MSIs. This patch fixes it. Signed-off-by: Alexey Kardashevskiy Signed-off-by: David Gibson Signed-off-by: Alexander Graf --- hw/spapr_pci.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/spapr_pci.c b/hw/spapr_pci.c index a08ed11..3c5b855 100644 --- a/hw/spapr_pci.c +++ b/hw/spapr_pci.c @@ -351,7 +351,7 @@ static void rtas_ibm_change_msi(sPAPREnvironment *spapr, /* There is no cached config, allocate MSIs */ if (!phb->msi_table[ndev].nvec) { - irq = spapr_allocate_irq_block(req_num, true); + irq = spapr_allocate_irq_block(req_num, false); if (irq < 0) { fprintf(stderr, "Cannot allocate MSIs for device#%d", ndev); rtas_st(rets, 0, -1); /* Hardware error */