Patchwork [1.3] target-i386: restore 'cvt16' CPUID feature

login
register
mail settings
Submitter Igor Mammedov
Date Nov. 26, 2012, 3:41 p.m.
Message ID <1353944478-27120-1-git-send-email-imammedo@redhat.com>
Download mbox | patch
Permalink /patch/201711/
State New
Headers show

Comments

Igor Mammedov - Nov. 26, 2012, 3:41 p.m.
commit c8acc380: target-i386/cpu: Name new CPUID bits
by mistake removed CPUID feature while adding new features,
restore it.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
CC: Eduardo Habkost <ehabkost@redhat.com>
---
 target-i386/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Eduardo Habkost - Nov. 26, 2012, 3:45 p.m.
On Mon, Nov 26, 2012 at 04:41:18PM +0100, Igor Mammedov wrote:
> commit c8acc380: target-i386/cpu: Name new CPUID bits
> by mistake removed CPUID feature while adding new features,
> restore it.

The feature name was removed on purpose. It was never supported by the
KVM kernel code in any kernel version. See
http://article.gmane.org/gmane.comp.emulators.qemu/176694

> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> CC: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-i386/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index a67958e..562d1d8 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -89,7 +89,7 @@ static const char *ext3_feature_name[] = {
>      "cr8legacy" /* AMD AltMovCr8 */, "abm", "sse4a", "misalignsse",
>      "3dnowprefetch", "osvw", "ibs", "xop",
>      "skinit", "wdt", NULL, "lwp",
> -    "fma4", "tce", NULL, "nodeid_msr",
> +    "fma4", "tce", "cvt16", "nodeid_msr",
>      NULL, "tbm", "topoext", "perfctr_core",
>      "perfctr_nb", NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
> -- 
> 1.7.11.7
>

Patch

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index a67958e..562d1d8 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -89,7 +89,7 @@  static const char *ext3_feature_name[] = {
     "cr8legacy" /* AMD AltMovCr8 */, "abm", "sse4a", "misalignsse",
     "3dnowprefetch", "osvw", "ibs", "xop",
     "skinit", "wdt", NULL, "lwp",
-    "fma4", "tce", NULL, "nodeid_msr",
+    "fma4", "tce", "cvt16", "nodeid_msr",
     NULL, "tbm", "topoext", "perfctr_core",
     "perfctr_nb", NULL, NULL, NULL,
     NULL, NULL, NULL, NULL,