Patchwork [U-Boot] fsl/sata: remove read only bit writing in host control register

login
register
mail settings
Submitter Zang Roy-R61911
Date Nov. 26, 2012, 5:04 a.m.
Message ID <1353906242-1661-1-git-send-email-tie-fei.zang@freescale.com>
Download mbox | patch
Permalink /patch/201624/
State Under Review
Delegated to: Anatolij Gustschin
Headers show

Comments

Zang Roy-R61911 - Nov. 26, 2012, 5:04 a.m.
HC_OFF bit in HControl register is read only bit, which
should not be written.

Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
---
check mpc8379, mpc8536, P3041, P5020 and T4240.
HC_OFF bit is read only.

 drivers/block/fsl_sata.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Patch

diff --git a/drivers/block/fsl_sata.c b/drivers/block/fsl_sata.c
index fda3389..f647545 100644
--- a/drivers/block/fsl_sata.c
+++ b/drivers/block/fsl_sata.c
@@ -190,7 +190,6 @@  int init_sata(int dev)
 	/* To have safe state, force the controller offline */
 	val32 = in_le32(&reg->hcontrol);
 	val32 &= ~HCONTROL_ONOFF;
-	val32 |= HCONTROL_FORCE_OFFLINE;
 	out_le32(&reg->hcontrol, val32);
 
 	/* Wait the controller offline */