From patchwork Sun Nov 25 18:08:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Henrik_Nordstr=C3=B6m?= X-Patchwork-Id: 201560 X-Patchwork-Delegate: wd@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 15ADA2C0082 for ; Mon, 26 Nov 2012 05:08:39 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 193FF4A0F1; Sun, 25 Nov 2012 19:08:37 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wpo2d3OOkS6T; Sun, 25 Nov 2012 19:08:36 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 361E04A0F4; Sun, 25 Nov 2012 19:08:34 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 082EE4A0F4 for ; Sun, 25 Nov 2012 19:08:32 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Eue-OuCbeIvd for ; Sun, 25 Nov 2012 19:08:30 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from vps1.hno.se (vps1.hno.se [31.192.227.87]) by theia.denx.de (Postfix) with ESMTPS id 3E4E94A0F1 for ; Sun, 25 Nov 2012 19:08:27 +0100 (CET) Received: from home.hno.se (home.hno.se [IPv6:2001:470:df90::1]) (authenticated bits=128) by vps1.hno.se (8.14.4/8.14.4) with ESMTP id qAPI8Nbp014453 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 25 Nov 2012 19:08:25 +0100 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by home.hno.se (8.14.5/8.14.5) with ESMTP id qAPI8JV5007894 for ; Sun, 25 Nov 2012 19:08:19 +0100 Message-ID: <1353866899.28559.57.camel@home.hno.se> From: Henrik =?ISO-8859-1?Q?Nordstr=F6m?= To: U-Boot Mailing List Date: Sun, 25 Nov 2012 19:08:19 +0100 In-Reply-To: <20121125174543.B9AFE20105B@gemini.denx.de> References: <1353842544.17518.11.camel@home.hno.se> <20121125174543.B9AFE20105B@gemini.denx.de> X-Mailer: Evolution 3.2.3 (3.2.3-3.fc16) Mime-Version: 1.0 Subject: Re: [U-Boot] [PATCH 2/2] Makefile: Accept target names in all lower case to ease matching X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de sön 2012-11-25 klockan 18:45 +0100 skrev Wolfgang Denk: > Dear Henrik Nordström, > > In message <1353842544.17518.11.camel@home.hno.se> you wrote: > > --- > > Makefile | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index 1a17be9..5a98745 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -752,6 +752,7 @@ unconfig: > > sinclude $(obj).boards.depend > > $(obj).boards.depend: boards.cfg > > @awk '(NF && $$1 !~ /^#/) { print $$1 ": " $$1 "_config; $$(MAKE)" }' $< > $@ > > + @awk '(NF && $$1 !~ /^#/ && tolower($$1) != $$1) { print tolower($$1) ": " $$1 "_config; $$(MAKE)" }' $< > $@ > > NAK. This is not DOS. Names are case sensitive. Ok, then I'll swing the patch in the other direction and make target names actually case sensitive. Because today they are a bit confused partially case-insensitive. Note that it's not about board config file names or directory names, only about the first column in boards.cfg. Regards Henrik --- From: Henrik Nordstrom Date: Sun, 25 Nov 2012 19:00:12 +0100 Subject: [PATCH] mkconfig: Make board name matching case-sensitive As per mail discussion board names are supposed to be case-sensitive --- mkconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mkconfig b/mkconfig index 7c9aa74..324703f 100755 --- a/mkconfig +++ b/mkconfig @@ -21,7 +21,7 @@ options="" if [ \( $# -eq 2 \) -a \( "$1" = "-A" \) ] ; then # Automatic mode - line=`egrep -i "^[[:space:]]*${2}[[:space:]]" boards.cfg` || { + line=`egrep "^[[:space:]]*${2}[[:space:]]" boards.cfg` || { echo "make: *** No rule to make target \`$2_config'. Stop." >&2 exit 1 }