Patchwork [U-Boot,2/2] MIPS: do not modify variable before relocate_code

login
register
mail settings
Submitter Zhi-zhou Zhang
Date Nov. 24, 2012, 3:07 p.m.
Message ID <1353769633-31374-4-git-send-email-zhizhou.zh@gmail.com>
Download mbox | patch
Permalink /patch/201490/
State Accepted
Delegated to: Daniel Schwierzeck
Headers show

Comments

Zhi-zhou Zhang - Nov. 24, 2012, 3:07 p.m.
Because timestamp is declared as `static', we needn't initialize
it by writing it a zero. If we do it before relocate_code, we
will write into a flash address(0xffffffffbfc0xxxx).

Signed-off-by: Zhi-zhou Zhang <zhizhou.zh@gmail.com>
---
 arch/mips/cpu/mips32/time.c |    1 -
 arch/mips/cpu/mips64/time.c |    1 -
 2 files changed, 2 deletions(-)

Patch

diff --git a/arch/mips/cpu/mips32/time.c b/arch/mips/cpu/mips32/time.c
index 350896a..09fc842 100644
--- a/arch/mips/cpu/mips32/time.c
+++ b/arch/mips/cpu/mips32/time.c
@@ -36,7 +36,6 @@  static unsigned long timestamp;
 int timer_init(void)
 {
 	/* Set up the timer for the first expiration. */
-	timestamp = 0;
 	write_c0_compare(read_c0_count() + CYCLES_PER_JIFFY);
 
 	return 0;
diff --git a/arch/mips/cpu/mips64/time.c b/arch/mips/cpu/mips64/time.c
index 5154280..720f7b7 100644
--- a/arch/mips/cpu/mips64/time.c
+++ b/arch/mips/cpu/mips64/time.c
@@ -37,7 +37,6 @@  static unsigned long timestamp;
 int timer_init(void)
 {
 	/* Set up the timer for the first expiration. */
-	timestamp = 0;
 	write_c0_compare(read_c0_count() + CYCLES_PER_JIFFY);
 
 	return 0;