From patchwork Sat Nov 24 22:54:07 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Evans X-Patchwork-Id: 201485 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 4AEA72C008D for ; Sun, 25 Nov 2012 09:54:21 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1354402461; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Date:Message-Id:From:To:Subject:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=2AheuisZf4ZJWU8AJjfsTGexky8=; b=ZI95VQVoob1eor+qLHjVveSVtiB5prsxx7z/0HZL8iP+H1RnJo0v0HMLF9Aoce +7fmAF39hZ6UpzWzT3ULv8fRwMwTs8iejJEcob3gjVqLQRpkwRjjxOD3ZKqZ1swv M1x2Z+Ik0th83E4UqmiA6IR0Cq0+9diDpTgx+KEFUmhhE= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:Received:Received:Received:Date:Message-Id:From:To:Subject:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Ag+lWINr/LC5NnOh+L/pW5cVll2tOXxPw6HcVhQt3rTFzfdU8mwnRzACAYDJCT Ueyb8NedRB79BkQjmlj/mKWSqMkadjJVQ/uTVWB0SQVcg7VvUB+SM9mGyG7Reepg zqxEdG2V99PpJNRiU9gSnDyS2PUJjEafzq0Xq/tY/pd9o=; Received: (qmail 2303 invoked by alias); 24 Nov 2012 22:54:17 -0000 Received: (qmail 2295 invoked by uid 22791); 24 Nov 2012 22:54:17 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-ee0-f73.google.com (HELO mail-ee0-f73.google.com) (74.125.83.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 24 Nov 2012 22:54:11 +0000 Received: by mail-ee0-f73.google.com with SMTP id d49so674058eek.2 for ; Sat, 24 Nov 2012 14:54:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:message-id:from:to:subject:x-gm-message-state; bh=5vjRUEYDPnJF2MkiZz0bNt0l12jtKboK8DzB7r7Mcfc=; b=TQgsk2BV3GLAWTlN/Odhyp+I/30Xgsl96+1Fy7eEWKTBF/P4dJHmQcq5jWWzZiRm1f esKNSftUPouzH7D7FG0psgYUvs8dgZA03XvonN9PeeLLXuDLahrm91Dw7/8hbNGZgVMO Md+dCBHz/4lYCy2W3+Kl9Rsrq6KAIiUCFGNWH+x7xdkBVcoG2oXD9wa918v1E3r7/YtK iOhLOt5DTrM6UupGf8j7gS8/n0moz7jnYeKDaUsJLvVMQEKLBJ9JJG/Jeyj7ocUiQIyx FAosmli8hRBE5+XeNuZXbx3YcKQCdF6Z/w5jKqn1CpEjKcxnHjqRDDsWNAPxmVHF2wLM 5Ljw== Received: by 10.14.209.66 with SMTP id r42mr10191509eeo.1.1353797649931; Sat, 24 Nov 2012 14:54:09 -0800 (PST) Received: from hpza10.eem.corp.google.com ([74.125.121.33]) by gmr-mx.google.com with ESMTPS id z47si2512950eel.0.2012.11.24.14.54.09 (version=TLSv1/SSLv3 cipher=AES128-SHA); Sat, 24 Nov 2012 14:54:09 -0800 (PST) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.17.128.107]) by hpza10.eem.corp.google.com (Postfix) with ESMTP id AACC720004E; Sat, 24 Nov 2012 14:54:08 -0800 (PST) Date: Sat, 24 Nov 2012 14:54:07 -0800 Message-Id: From: Doug Evans To: dnovillo@google.com, gcc-patches@gcc.gnu.org Subject: [RFA 6/8] validate_failures.py: remove pass/fail from GetBuildData X-Gm-Message-State: ALoCoQkg3BOpm9I1kwS28McBnQb5rydVNcNn0Ja+v+KcjyVa+JCx7cVM0S6ml1H8Wz3P8pQGE9QzFcWuokhIlnBj14VCvgQpyCLX6QokcB8AHWBzhny4pTS3nhoZGqTWvdqLkfPpBtKP8m1pyMUVsBOqTmR7IqfTE5i2rZrYJJiHE7UVzTW2+BFfLn00Npf1WKo81sj4s+XIYNmpPvH4R4W0CBwgzVvycw== X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi. This sixth patch simplifies calls to GetBuildData. It never returns false and always terminates the process with an error message (which is fine by me). Ok to check in? 2012-11-24 Doug Evans * testsuite-management/validate_failures.py: Remove pass/fail indicator from result of GetBuildData. --- validate_failures.py.options 2012-11-24 13:40:57.616245431 -0800 +++ validate_failures.py 2012-11-24 13:44:05.118039626 -0800 @@ -284,7 +284,7 @@ def GetBuildData(): options.build_dir) print 'Source directory: %s' % srcdir print 'Build target: %s' % target - return srcdir, target, True + return srcdir, target def PrintSummary(msg, summary): @@ -326,9 +326,7 @@ def PerformComparison(expected, actual, def CheckExpectedResults(): if not options.manifest: - (srcdir, target, valid_build) = GetBuildData() - if not valid_build: - return False + (srcdir, target) = GetBuildData() manifest_path = _MANIFEST_PATH_PATTERN % (srcdir, target) else: manifest_path = options.manifest @@ -348,10 +346,7 @@ def CheckExpectedResults(): def ProduceManifest(): - (srcdir, target, valid_build) = GetBuildData() - if not valid_build: - return False - + (srcdir, target) = GetBuildData() manifest_path = _MANIFEST_PATH_PATTERN % (srcdir, target) if os.path.exists(manifest_path) and not options.force: Error('Manifest file %s already exists.\nUse --force to overwrite.' % @@ -369,9 +364,7 @@ def ProduceManifest(): def CompareBuilds(): - (srcdir, target, valid_build) = GetBuildData() - if not valid_build: - return False + (srcdir, target) = GetBuildData() sum_files = GetSumFiles(options.results, options.build_dir) actual = GetResults(sum_files)