From patchwork Sat Nov 24 22:47:10 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Evans X-Patchwork-Id: 201482 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 257742C008D for ; Sun, 25 Nov 2012 09:47:29 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1354402050; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Date:Message-Id:From:To:Subject:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=+f5Kw8001fVXRFqKai2jmEl7q/E=; b=tOilLKZ8FbTPJeyZ8wq+ikv5hO7rEXWUguydvPVdi44C4p6rfX0FfyfUW8R3wk aYzSaQcmwyL3+dE70QIgxMqf6M2SJoXCesclMKVyEEGmZxGPgHmaGQaFe09LNf/R k71Jb+eiInWfvZQ4ZzH1yVu454o20FQdFZvW0LRB6zL/k= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:Received:Received:Received:Date:Message-Id:From:To:Subject:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=LwXbanGogRvzRWL4Z6X1qEyYvVhW7oH6XyIqkLSsHMYQ6R3QOxhpZu0GRW7paK V9OuDpByFIM/xeR3r28OAmQlGTUL0/tVlmMJvZ2a0Kv8Rq2LDTlxSqAQCNqOGv+O Sc7AVng9r8GCE8LNpC17gcj7aoCuX6LsW72BziYi0YAdQ=; Received: (qmail 30309 invoked by alias); 24 Nov 2012 22:47:23 -0000 Received: (qmail 30301 invoked by uid 22791); 24 Nov 2012 22:47:21 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-gh0-f201.google.com (HELO mail-gh0-f201.google.com) (209.85.160.201) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 24 Nov 2012 22:47:13 +0000 Received: by mail-gh0-f201.google.com with SMTP id z19so939468ghb.2 for ; Sat, 24 Nov 2012 14:47:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:message-id:from:to:subject:x-gm-message-state; bh=lIZiEbT1MrnsK5qeUjCxZvm7zYnjHHoEo0P55zppFKw=; b=YS+oM7RiOwSNxzUEiyJx9uYY/7t0ePwKfiigT5tqZLpjS0WzZho8g1ad1xRNhPpRlH HhJCgMfuBaCidLGNfLC8t8wb/a1YsnJXiVChjHKdv7RVJc+Qx6vZ1ieaTWlTJ61MzA5i 4P13gRAIHZ/AAKWZEEvZk0HRALemN2J3pSPfdeGzsIesNfVAai5BesEt8ytuHM6QpFZc ojjYWje8XURuzjjiBygqA4P8e50V/jRvJuFn2P9XMlnwFN9bqPsgLnibZ7HriTKBkU02 RmKd3sT4cjzLLUNvwgYo7pouwDbDuKbaOAjmbJtlZ3SZze67WD6CjIzbS1YGdAXOAiDs SL6w== Received: by 10.236.151.39 with SMTP id a27mr5321789yhk.42.1353797231856; Sat, 24 Nov 2012 14:47:11 -0800 (PST) Received: from wpzn4.hot.corp.google.com (216-239-44-65.google.com [216.239.44.65]) by gmr-mx.google.com with ESMTPS id i63si724618yhk.5.2012.11.24.14.47.11 (version=TLSv1/SSLv3 cipher=AES128-SHA); Sat, 24 Nov 2012 14:47:11 -0800 (PST) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.17.128.107]) by wpzn4.hot.corp.google.com (Postfix) with ESMTP id 575A782004A; Sat, 24 Nov 2012 14:47:11 -0800 (PST) Date: Sat, 24 Nov 2012 14:47:10 -0800 Message-Id: From: Doug Evans To: dnovillo@google.com, gcc-patches@gcc.gnu.org Subject: [RFA 3/8] validate_failures.py: pass options.results for clean build case X-Gm-Message-State: ALoCoQlzEGDZZ/i3srY8uYV2Pp1G1o7p3nHgZiIIC+8lP3QFttVafBR3WDIa1Ir0N1jiMZdAiEmAOlZfJRenC4iU4LHOz18lhmF75wR7aSZHVLcsRwYnoXfgrkpvR88MCATKqtopoEgC8ly8gMtenQoTnhbbrc6gZMb3tdiAynLo+8u4N69Jvw2KM32eT41meS9UnDllmTaUJTuE6JHMSmxPgRbPQGd04A== X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi. This third patch passes options.results to GetSumFiles when fetching the results for the clean build. It is useful in my use cases, but I'm not sure it's useful for upstream. [An alternative is to add another option to specify the results file(s) for the clean build, but I'm being conservative and not adding an option if I don't have to.] Ok to check in? 2012-11-24 Doug Evans * testsuite-management/validate_failures.py (CompareBuilds): Pass options.results to GetSumFiles for clean build. --- validate_failures.py= 2012-11-19 11:47:29.997632548 -0800 +++ validate_failures.py 2012-11-24 13:26:07.727726123 -0800 @@ -373,7 +373,7 @@ def CompareBuilds(options): sum_files = GetSumFiles(options.results, options.build_dir) actual = GetResults(sum_files) - clean_sum_files = GetSumFiles(None, options.clean_build) + clean_sum_files = GetSumFiles(options.results, options.clean_build) clean = GetResults(clean_sum_files) return PerformComparison(clean, actual, options.ignore_missing_failures)