Patchwork [RFA,2/8] validate_failures.py: use target_alias

login
register
mail settings
Submitter Doug Evans
Date Nov. 24, 2012, 10:43 p.m.
Message ID <yjt238zy7hb9.fsf@ruffy2.mtv.corp.google.com>
Download mbox | patch
Permalink /patch/201481/
State New
Headers show

Comments

Doug Evans - Nov. 24, 2012, 10:43 p.m.
Hi.
This second patch uses "target_alias" instead of "target" in the help text,
and makes some minor whitespace changes.

Ok to check in?

2012-11-24  Doug Evans  <dje@google.com>

	* testsuite-management/validate_failures.py: Use <target_alias> instead of
	<target>.  Minor whitespace changes.
Diego Novillo - Nov. 25, 2012, 3:34 p.m.
On Sat, Nov 24, 2012 at 5:43 PM, Doug Evans <dje@google.com> wrote:

> 2012-11-24  Doug Evans  <dje@google.com>
>
>         * testsuite-management/validate_failures.py: Use <target_alias>
> instead of
>         <target>.  Minor whitespace changes.

OK.


Diego.

Patch

--- validate_failures.py=	2012-11-19 11:47:29.997632548 -0800
+++ validate_failures.py	2012-11-24 13:22:25.805598185 -0800
@@ -217,8 +217,7 @@  def GetManifest(manifest_name):
   Each entry in the manifest file should have the format understood
   by the TestResult constructor.
 
-  If no manifest file exists for this target, it returns an empty
-  set.
+  If no manifest file exists for this target, it returns an empty set.
   """
   if os.path.exists(manifest_name):
     return ParseSummary(manifest_name)
@@ -409,7 +408,7 @@  def Main(argv):
   parser.add_option('--manifest', action='store', type='string',
                     dest='manifest', default=None,
                     help='Name of the manifest file to use (default = '
-                    'taken from contrib/testsuite-managment/<target>.xfail)')
+                    'taken from contrib/testsuite-managment/<target_alias>.xfail)')
   parser.add_option('--produce_manifest', action='store_true',
                     dest='produce_manifest', default=False,
                     help='Produce the manifest for the current '
@@ -436,6 +435,7 @@  def Main(argv):
   else:
     return 1
 
+
 if __name__ == '__main__':
   retval = Main(sys.argv)
   sys.exit(retval)