From patchwork Sat Nov 24 09:41:25 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans-Peter Nilsson X-Patchwork-Id: 201447 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 5E6742C007A for ; Sat, 24 Nov 2012 20:41:33 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1354354895; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Date:From:To:Subject:Message-ID:User-Agent:MIME-Version: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=8uKvieb 6hptd94l3xP1dNOZ8LAI=; b=BqditFXFVe7V2gFd4F9uzFw/jMyVCH0OjWIzkcs NsXiwztqB2wySu16Xy7csUsjkjFHoIXS7vsrFmo8faNBH3Hl7lvrJmCzRDokYzWE UkgwftvGPGayoLX6zx+cmVaVd0JbSOADFYgHat1sCD6BLOfN7OhnbDfvYamAwK0d USik= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Date:From:To:Subject:Message-ID:User-Agent:MIME-Version:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=lLxEUQomr1TCTFv+0mNy2JAceOJcT3oT/XIquYrlCu8zJurhS11Awbq+SJ3xLs d1eBXNbPCm89/jnoaBfHpWQtQNFE0CPelS4MeN7btFF+5smEcCp5PreJAE7Ok/84 TL2XHdqbDx8oqZqJAvxJjekOv/dLKP4NjzdW98sXWmTZY=; Received: (qmail 31536 invoked by alias); 24 Nov 2012 09:41:30 -0000 Received: (qmail 31528 invoked by uid 22791); 24 Nov 2012 09:41:30 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,TW_BV X-Spam-Check-By: sourceware.org Received: from dair.pair.com (HELO dair.pair.com) (209.68.1.49) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sat, 24 Nov 2012 09:41:27 +0000 Received: (qmail 67403 invoked by uid 20157); 24 Nov 2012 09:41:25 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 24 Nov 2012 09:41:25 -0000 Date: Sat, 24 Nov 2012 04:41:25 -0500 (EST) From: Hans-Peter Nilsson To: gcc-patches@gcc.gnu.org Subject: Committed: handle negative numbers in gcc-gdb-test.exp Message-ID: User-Agent: Alpine 2.02 (BSF 1266 2009-07-14) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Without this, I got weird ERRORs and those Tcl backtraces you come to hate, instead of the expected FAILs. Committed as obvious after running a failing guality test and obvserving the intended change. (Well ok, *adding an explanatory comment* is apparently not obvious, but I'll take that liberty...) testsuite: * lib/gcc-gdb-test.exp (gdb-test): Pass -- as first argument to to send_log. brgds, H-P Index: gcc/testsuite/lib/gcc-gdb-test.exp =================================================================== --- gcc/testsuite/lib/gcc-gdb-test.exp (revision 192677) +++ gcc/testsuite/lib/gcc-gdb-test.exp (working copy) @@ -74,7 +74,9 @@ proc gdb-test { args } { if { $first == $second } { pass "$testname" } else { - send_log "$first != $second\n" + # We need the -- to disambiguate $first from an option, + # as it may be negative. + send_log -- "$first != $second\n" fail "$testname" } remote_close target